third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp - Issue 2366693005: Mark paragraph-related functions deprecated in VisibleUnits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

Issue 2366693005: Mark paragraph-related functions deprecated in VisibleUnits (Closed)

Patch Set: Add output for DCHECK Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp b/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

index 5269a6c091e81b15184b11ac334972ea3f41f82b..6621da891031f6debb85f00a7711e9090ac98b40 100644

--- a/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp

@@ -98,7 +98,7 @@ void FormatBlockCommand::formatRange(const Position& start, const Position& end,

}

Position lastParagraphInBlockNode = blockElement->lastChild() ? Position::afterNode(blockElement->lastChild()) : Position();

- bool wasEndOfParagraph = isEndOfParagraph(createVisiblePositionDeprecated(lastParagraphInBlockNode));

+ bool wasEndOfParagraph = isEndOfParagraphDeprecated(createVisiblePositionDeprecated(lastParagraphInBlockNode));

moveParagraphWithClones(createVisiblePositionDeprecated(start), createVisiblePositionDeprecated(end), blockElement, outerBlock, editingState);

if (editingState->isAborted())

@@ -108,7 +108,7 @@ void FormatBlockCommand::formatRange(const Position& start, const Position& end,

if (outerBlock != nodeAfterInsertionPosition && toHTMLElement(nodeAfterInsertionPosition)->hasAttribute(styleAttr))

blockElement->setAttribute(styleAttr, toHTMLElement(nodeAfterInsertionPosition)->getAttribute(styleAttr));

- if (wasEndOfParagraph && !isEndOfParagraph(createVisiblePositionDeprecated(lastParagraphInBlockNode)) && !isStartOfParagraph(createVisiblePositionDeprecated(lastParagraphInBlockNode)))

+ if (wasEndOfParagraph && !isEndOfParagraphDeprecated(createVisiblePositionDeprecated(lastParagraphInBlockNode)) && !isStartOfParagraphDeprecated(createVisiblePositionDeprecated(lastParagraphInBlockNode)))

insertBlockPlaceholder(lastParagraphInBlockNode, editingState);

}