Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/Source/core/editing/VisibleUnits.h

Issue 2366693005: Mark paragraph-related functions deprecated in VisibleUnits (Closed)
Patch Set: Add output for DCHECK Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 CORE_EXPORT VisiblePositionInFlatTree endOfParagraph(const VisiblePositionInFlat Tree&, EditingBoundaryCrossingRule = CannotCrossEditingBoundary); 201 CORE_EXPORT VisiblePositionInFlatTree endOfParagraph(const VisiblePositionInFlat Tree&, EditingBoundaryCrossingRule = CannotCrossEditingBoundary);
202 VisiblePosition startOfNextParagraph(const VisiblePosition&); 202 VisiblePosition startOfNextParagraph(const VisiblePosition&);
203 VisiblePosition previousParagraphPosition(const VisiblePosition&, LayoutUnit x); 203 VisiblePosition previousParagraphPosition(const VisiblePosition&, LayoutUnit x);
204 VisiblePosition nextParagraphPosition(const VisiblePosition&, LayoutUnit x); 204 VisiblePosition nextParagraphPosition(const VisiblePosition&, LayoutUnit x);
205 CORE_EXPORT bool isStartOfParagraph(const VisiblePosition&, EditingBoundaryCross ingRule = CannotCrossEditingBoundary); 205 CORE_EXPORT bool isStartOfParagraph(const VisiblePosition&, EditingBoundaryCross ingRule = CannotCrossEditingBoundary);
206 CORE_EXPORT bool isStartOfParagraph(const VisiblePositionInFlatTree&, EditingBou ndaryCrossingRule = CannotCrossEditingBoundary); 206 CORE_EXPORT bool isStartOfParagraph(const VisiblePositionInFlatTree&, EditingBou ndaryCrossingRule = CannotCrossEditingBoundary);
207 CORE_EXPORT bool isEndOfParagraph(const VisiblePosition&, EditingBoundaryCrossin gRule = CannotCrossEditingBoundary); 207 CORE_EXPORT bool isEndOfParagraph(const VisiblePosition&, EditingBoundaryCrossin gRule = CannotCrossEditingBoundary);
208 CORE_EXPORT bool isEndOfParagraph(const VisiblePositionInFlatTree&, EditingBound aryCrossingRule = CannotCrossEditingBoundary); 208 CORE_EXPORT bool isEndOfParagraph(const VisiblePositionInFlatTree&, EditingBound aryCrossingRule = CannotCrossEditingBoundary);
209 bool inSameParagraph(const VisiblePosition&, const VisiblePosition&, EditingBoun daryCrossingRule = CannotCrossEditingBoundary); 209 bool inSameParagraph(const VisiblePosition&, const VisiblePosition&, EditingBoun daryCrossingRule = CannotCrossEditingBoundary);
210 210
211 // These deprecated functions perform synchronous layout, messing up the
212 // rendering pipeline. They may also take invalid VisiblePositions as their
213 // arguments. Callers should ensure clean layout and pass valid VisiblePositions
214 // to the un-deprecated functions listed above.
215 CORE_EXPORT VisiblePosition startOfParagraphDeprecated(const VisiblePosition&, E ditingBoundaryCrossingRule = CannotCrossEditingBoundary);
216 CORE_EXPORT VisiblePositionInFlatTree startOfParagraphDeprecated(const VisiblePo sitionInFlatTree&, EditingBoundaryCrossingRule = CannotCrossEditingBoundary);
217 CORE_EXPORT VisiblePosition endOfParagraphDeprecated(const VisiblePosition&, Edi tingBoundaryCrossingRule = CannotCrossEditingBoundary);
218 CORE_EXPORT VisiblePositionInFlatTree endOfParagraphDeprecated(const VisiblePosi tionInFlatTree&, EditingBoundaryCrossingRule = CannotCrossEditingBoundary);
219 VisiblePosition startOfNextParagraphDeprecated(const VisiblePosition&);
220 CORE_EXPORT bool isStartOfParagraphDeprecated(const VisiblePosition&, EditingBou ndaryCrossingRule = CannotCrossEditingBoundary);
221 CORE_EXPORT bool isStartOfParagraphDeprecated(const VisiblePositionInFlatTree&, EditingBoundaryCrossingRule = CannotCrossEditingBoundary);
222 CORE_EXPORT bool isEndOfParagraphDeprecated(const VisiblePosition&, EditingBound aryCrossingRule = CannotCrossEditingBoundary);
223 CORE_EXPORT bool isEndOfParagraphDeprecated(const VisiblePositionInFlatTree&, Ed itingBoundaryCrossingRule = CannotCrossEditingBoundary);
224 bool inSameParagraphDeprecated(const VisiblePosition&, const VisiblePosition&, E ditingBoundaryCrossingRule = CannotCrossEditingBoundary);
225
211 // blocks (true paragraphs; line break elements don't break blocks) 226 // blocks (true paragraphs; line break elements don't break blocks)
212 VisiblePosition startOfBlock(const VisiblePosition&, EditingBoundaryCrossingRule = CannotCrossEditingBoundary); 227 VisiblePosition startOfBlock(const VisiblePosition&, EditingBoundaryCrossingRule = CannotCrossEditingBoundary);
213 VisiblePosition endOfBlock(const VisiblePosition&, EditingBoundaryCrossingRule = CannotCrossEditingBoundary); 228 VisiblePosition endOfBlock(const VisiblePosition&, EditingBoundaryCrossingRule = CannotCrossEditingBoundary);
214 bool inSameBlock(const VisiblePosition&, const VisiblePosition&); 229 bool inSameBlock(const VisiblePosition&, const VisiblePosition&);
215 bool isStartOfBlock(const VisiblePosition&); 230 bool isStartOfBlock(const VisiblePosition&);
216 bool isEndOfBlock(const VisiblePosition&); 231 bool isEndOfBlock(const VisiblePosition&);
217 232
218 // document 233 // document
219 CORE_EXPORT VisiblePosition startOfDocument(const VisiblePosition&); 234 CORE_EXPORT VisiblePosition startOfDocument(const VisiblePosition&);
220 CORE_EXPORT VisiblePositionInFlatTree startOfDocument(const VisiblePositionInFla tTree&); 235 CORE_EXPORT VisiblePositionInFlatTree startOfDocument(const VisiblePositionInFla tTree&);
(...skipping 22 matching lines...) Expand all
243 258
244 // Returns a hit-tested VisiblePosition for the given point in contents-space 259 // Returns a hit-tested VisiblePosition for the given point in contents-space
245 // coordinates. 260 // coordinates.
246 CORE_EXPORT VisiblePosition visiblePositionForContentsPoint(const IntPoint&, Loc alFrame*); 261 CORE_EXPORT VisiblePosition visiblePositionForContentsPoint(const IntPoint&, Loc alFrame*);
247 262
248 CORE_EXPORT bool rendersInDifferentPosition(const Position&, const Position&); 263 CORE_EXPORT bool rendersInDifferentPosition(const Position&, const Position&);
249 264
250 } // namespace blink 265 } // namespace blink
251 266
252 #endif // VisibleUnits_h 267 #endif // VisibleUnits_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698