third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp - Issue 2366693005: Mark paragraph-related functions deprecated in VisibleUnits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

Issue 2366693005: Mark paragraph-related functions deprecated in VisibleUnits (Closed)

Patch Set: Add output for DCHECK Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

index a702f6088b141924fe3d03b3c7f43e0792d47575..46e2b6caab627cbb2048593c5f44e9ae7aae9307 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

@@ -170,7 +170,7 @@ void InsertTextCommand::doApply(EditingState* editingState)

if (lineBreakExistsAtPosition(downstream)) {

// FIXME: This doesn't handle placeholders at the end of anonymous blocks.

VisiblePosition caret = createVisiblePositionDeprecated(startPosition);

- if (isEndOfBlock(caret) && isStartOfParagraph(caret))

+ if (isEndOfBlock(caret) && isStartOfParagraphDeprecated(caret))

placeholder = downstream;

// Don't remove the placeholder yet, otherwise the block we're inserting into would collapse before

// we get a chance to insert into it. We check for a placeholder now, though, because doing so requires