Source/bindings/v8/custom/V8MutationObserverCustom.cpp - Issue 236653002: Oilpan: move mutation observers to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8MutationObserverCustom.cpp

Issue 236653002: Oilpan: move mutation observers to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + explicitly dispose() mutation observer registrations always (non-Oilpan also.) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/custom/V8MutationObserverCustom.cpp

diff --git a/Source/bindings/v8/custom/V8MutationObserverCustom.cpp b/Source/bindings/v8/custom/V8MutationObserverCustom.cpp

index 18408793d7e62ed60541211ba0eecb8abd8e32b9..12445611bc2d0d5629d048c4540ff5b4d04318b2 100644

--- a/Source/bindings/v8/custom/V8MutationObserverCustom.cpp

+++ b/Source/bindings/v8/custom/V8MutationObserverCustom.cpp

@@ -61,7 +61,7 @@ void V8MutationObserver::constructorCustom(const v8::FunctionCallbackInfo<v8::Va

v8::Handle<v8::Object> wrapper = info.Holder();

OwnPtr<MutationCallback> callback = V8MutationCallback::create(v8::Handle<v8::Function>::Cast(arg), context, wrapper, info.GetIsolate());

- RefPtr<MutationObserver> observer = MutationObserver::create(callback.release());

+ RefPtrWillBeRawPtr<MutationObserver> observer = MutationObserver::create(callback.release());

V8DOMWrapper::associateObjectWithWrapper<V8MutationObserver>(observer.release(), &wrapperTypeInfo, wrapper, info.GetIsolate(), WrapperConfiguration::Dependent);

info.GetReturnValue().Set(wrapper);

« no previous file with comments | « Source/bindings/v8/V8MutationCallback.cpp ('k') | Source/core/css/PropertySetCSSStyleDeclaration.cpp » ('j') | Source/core/dom/NodeRareData.h » ('J')