Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: Source/bindings/v8/custom/V8MutationObserverCustom.cpp

Issue 236653002: Oilpan: move mutation observers to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + explicitly dispose() mutation observer registrations always (non-Oilpan also.) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 if (!arg->IsFunction()) { 54 if (!arg->IsFunction()) {
55 exceptionState.throwTypeError("Callback argument must be a function"); 55 exceptionState.throwTypeError("Callback argument must be a function");
56 exceptionState.throwIfNeeded(); 56 exceptionState.throwIfNeeded();
57 return; 57 return;
58 } 58 }
59 59
60 ExecutionContext* context = currentExecutionContext(info.GetIsolate()); 60 ExecutionContext* context = currentExecutionContext(info.GetIsolate());
61 v8::Handle<v8::Object> wrapper = info.Holder(); 61 v8::Handle<v8::Object> wrapper = info.Holder();
62 62
63 OwnPtr<MutationCallback> callback = V8MutationCallback::create(v8::Handle<v8 ::Function>::Cast(arg), context, wrapper, info.GetIsolate()); 63 OwnPtr<MutationCallback> callback = V8MutationCallback::create(v8::Handle<v8 ::Function>::Cast(arg), context, wrapper, info.GetIsolate());
64 RefPtr<MutationObserver> observer = MutationObserver::create(callback.releas e()); 64 RefPtrWillBeRawPtr<MutationObserver> observer = MutationObserver::create(cal lback.release());
65 65
66 V8DOMWrapper::associateObjectWithWrapper<V8MutationObserver>(observer.releas e(), &wrapperTypeInfo, wrapper, info.GetIsolate(), WrapperConfiguration::Depende nt); 66 V8DOMWrapper::associateObjectWithWrapper<V8MutationObserver>(observer.releas e(), &wrapperTypeInfo, wrapper, info.GetIsolate(), WrapperConfiguration::Depende nt);
67 info.GetReturnValue().Set(wrapper); 67 info.GetReturnValue().Set(wrapper);
68 } 68 }
69 69
70 void V8MutationObserver::visitDOMWrapper(void* object, const v8::Persistent<v8:: Object>& wrapper, v8::Isolate* isolate) 70 void V8MutationObserver::visitDOMWrapper(void* object, const v8::Persistent<v8:: Object>& wrapper, v8::Isolate* isolate)
71 { 71 {
72 MutationObserver* observer = static_cast<MutationObserver*>(object); 72 MutationObserver* observer = static_cast<MutationObserver*>(object);
73 HashSet<Node*> observedNodes = observer->getObservedNodes(); 73 HashSet<Node*> observedNodes = observer->getObservedNodes();
74 for (HashSet<Node*>::iterator it = observedNodes.begin(); it != observedNode s.end(); ++it) { 74 for (HashSet<Node*>::iterator it = observedNodes.begin(); it != observedNode s.end(); ++it) {
75 v8::UniqueId id(reinterpret_cast<intptr_t>(V8GCController::opaqueRootFor GC(*it, isolate))); 75 v8::UniqueId id(reinterpret_cast<intptr_t>(V8GCController::opaqueRootFor GC(*it, isolate)));
76 isolate->SetReferenceFromGroup(id, wrapper); 76 isolate->SetReferenceFromGroup(id, wrapper);
77 } 77 }
78 } 78 }
79 79
80 } // namespace WebCore 80 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698