Source/core/css/PropertySetCSSStyleDeclaration.cpp - Issue 236653002: Oilpan: move mutation observers to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/PropertySetCSSStyleDeclaration.cpp

Issue 236653002: Oilpan: move mutation observers to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + explicitly dispose() mutation observer registrations always (non-Oilpan also.) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/PropertySetCSSStyleDeclaration.cpp

diff --git a/Source/core/css/PropertySetCSSStyleDeclaration.cpp b/Source/core/css/PropertySetCSSStyleDeclaration.cpp

index dbf13d03b62ee0cb13149edbe0ae0e09a3225714..9c1b6d878c14bf52aacb9a4387ea5827515e1019 100644

--- a/Source/core/css/PropertySetCSSStyleDeclaration.cpp

+++ b/Source/core/css/PropertySetCSSStyleDeclaration.cpp

@@ -41,6 +41,7 @@ namespace {

class StyleAttributeMutationScope {

WTF_MAKE_NONCOPYABLE(StyleAttributeMutationScope);

+ STACK_ALLOCATED();

public:

StyleAttributeMutationScope(AbstractPropertySetCSSStyleDeclaration* decl)

{

@@ -114,8 +115,8 @@ private:

static bool s_shouldNotifyInspector;

static bool s_shouldDeliver;

- OwnPtr<MutationObserverInterestGroup> m_mutationRecipients;

- RefPtr<MutationRecord> m_mutation;

+ OwnPtrWillBeMember<MutationObserverInterestGroup> m_mutationRecipients;

+ RefPtrWillBeMember<MutationRecord> m_mutation;

};

unsigned StyleAttributeMutationScope::s_scopeCount = 0;

« no previous file with comments | « Source/bindings/v8/custom/V8MutationObserverCustom.cpp ('k') | Source/core/dom/CharacterData.cpp » ('j') | Source/core/dom/NodeRareData.h » ('J')