Source/bindings/v8/V8MutationCallback.cpp - Issue 236653002: Oilpan: move mutation observers to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8MutationCallback.cpp

Issue 236653002: Oilpan: move mutation observers to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + explicitly dispose() mutation observer registrations always (non-Oilpan also.) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/V8MutationCallback.cpp

diff --git a/Source/bindings/v8/V8MutationCallback.cpp b/Source/bindings/v8/V8MutationCallback.cpp

index 1f0ce99dbd5a702784b343db3ff5d83cad07f1f5..b0822d0469e2b9e64a6417e285e45f4f0757459c 100644

--- a/Source/bindings/v8/V8MutationCallback.cpp

+++ b/Source/bindings/v8/V8MutationCallback.cpp

@@ -45,7 +45,7 @@ V8MutationCallback::V8MutationCallback(v8::Handle<v8::Function> callback, Execut

m_callback.setWeak(this, &setWeakCallback);

}

-void V8MutationCallback::call(const Vector<RefPtr<MutationRecord> >& mutations, MutationObserver* observer)

+void V8MutationCallback::call(const WillBeHeapVector<RefPtrWillBeMember<MutationRecord> >& mutations, MutationObserver* observer)

{

if (!canInvokeCallback())

return;

« no previous file with comments | « Source/bindings/v8/V8MutationCallback.h ('k') | Source/bindings/v8/custom/V8MutationObserverCustom.cpp » ('j') | Source/core/dom/NodeRareData.h » ('J')