Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: Source/bindings/v8/V8MutationCallback.cpp

Issue 236653002: Oilpan: move mutation observers to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + explicitly dispose() mutation observer registrations always (non-Oilpan also.) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 27 matching lines...) Expand all
38 38
39 V8MutationCallback::V8MutationCallback(v8::Handle<v8::Function> callback, Execut ionContext* context, v8::Handle<v8::Object> owner, v8::Isolate* isolate) 39 V8MutationCallback::V8MutationCallback(v8::Handle<v8::Function> callback, Execut ionContext* context, v8::Handle<v8::Object> owner, v8::Isolate* isolate)
40 : ActiveDOMCallback(context) 40 : ActiveDOMCallback(context)
41 , m_callback(isolate, callback) 41 , m_callback(isolate, callback)
42 , m_scriptState(NewScriptState::current(isolate)) 42 , m_scriptState(NewScriptState::current(isolate))
43 { 43 {
44 V8HiddenValue::setHiddenValue(isolate, owner, V8HiddenValue::callback(isolat e), callback); 44 V8HiddenValue::setHiddenValue(isolate, owner, V8HiddenValue::callback(isolat e), callback);
45 m_callback.setWeak(this, &setWeakCallback); 45 m_callback.setWeak(this, &setWeakCallback);
46 } 46 }
47 47
48 void V8MutationCallback::call(const Vector<RefPtr<MutationRecord> >& mutations, MutationObserver* observer) 48 void V8MutationCallback::call(const WillBeHeapVector<RefPtrWillBeMember<Mutation Record> >& mutations, MutationObserver* observer)
49 { 49 {
50 if (!canInvokeCallback()) 50 if (!canInvokeCallback())
51 return; 51 return;
52 52
53 v8::Isolate* isolate = m_scriptState->isolate(); 53 v8::Isolate* isolate = m_scriptState->isolate();
54 v8::HandleScope handleScope(isolate); 54 v8::HandleScope handleScope(isolate);
55 55
56 v8::Handle<v8::Context> v8Context = m_scriptState->context(); 56 v8::Handle<v8::Context> v8Context = m_scriptState->context();
57 if (v8Context.IsEmpty()) 57 if (v8Context.IsEmpty())
58 return; 58 return;
(...skipping 21 matching lines...) Expand all
80 exceptionCatcher.SetVerbose(true); 80 exceptionCatcher.SetVerbose(true);
81 ScriptController::callFunction(executionContext(), callback, thisObject, 2, argv, isolate); 81 ScriptController::callFunction(executionContext(), callback, thisObject, 2, argv, isolate);
82 } 82 }
83 83
84 void V8MutationCallback::setWeakCallback(const v8::WeakCallbackData<v8::Function , V8MutationCallback>& data) 84 void V8MutationCallback::setWeakCallback(const v8::WeakCallbackData<v8::Function , V8MutationCallback>& data)
85 { 85 {
86 data.GetParameter()->m_callback.clear(); 86 data.GetParameter()->m_callback.clear();
87 } 87 }
88 88
89 } // namespace WebCore 89 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698