Source/bindings/v8/V8MutationCallback.h - Issue 236653002: Oilpan: move mutation observers to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8MutationCallback.h

Issue 236653002: Oilpan: move mutation observers to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + explicitly dispose() mutation observer registrations always (non-Oilpan also.) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/V8MutationCallback.h

diff --git a/Source/bindings/v8/V8MutationCallback.h b/Source/bindings/v8/V8MutationCallback.h

index 8cc559001570d53ebc2c6bf476587077e0506b72..b2f5b2b8f61073f78e5e539a14f47a26cda6a670 100644

--- a/Source/bindings/v8/V8MutationCallback.h

+++ b/Source/bindings/v8/V8MutationCallback.h

@@ -46,7 +46,7 @@ public:

return adoptPtr(new V8MutationCallback(callback, context, owner, isolate));

}

- virtual void call(const Vector<RefPtr<MutationRecord> >&, MutationObserver*) OVERRIDE;

+ virtual void call(const WillBeHeapVector<RefPtrWillBeMember<MutationRecord> >&, MutationObserver*) OVERRIDE;

virtual ExecutionContext* executionContext() const OVERRIDE { return ContextLifecycleObserver::executionContext(); }

private:

« no previous file with comments | « no previous file | Source/bindings/v8/V8MutationCallback.cpp » ('j') | Source/core/dom/NodeRareData.h » ('J')