[Sync] Removed passphrase helper methods, removed ((n)) pattern, and fixed lint violations.

[Sync] Removed passphrase helper methods, removed ((n))
pattern, and fixed lint violations.

BUG=647875
Committed: https://crrev.com/cbb25ab10573f470c79ef624c1896a3830cc185f
Cr-Commit-Position: refs/heads/master@{#420698}

[skym, 2016-09-22 23:31:41]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 23:33:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 23:55:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:55:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skym, 2016-09-23 16:58:06]

Description was changed from

==========
[Sync] Moved passphrase helper methods into SyncTest, removed ((n)) pattern,
and fixed lint violations.

BUG=647875
==========

to

==========
[Sync] Moved passphrase helper methods into SyncTest, removed ((n)) pattern,
and fixed lint violations.

BUG=647875
==========

[skym, 2016-09-23 16:58:06]

skym@chromium.org changed reviewers:
+ maxbogue@chromium.org

[skym, 2016-09-23 16:58:29]

PTAL. I don't _think_ the try bot failures are my fault...

[maxbogue, 2016-09-23 17:39:37]

https://codereview.chromium.org/2365763002/diff/1/chrome/browser/sync/test/in...
File chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc
(right):

https://codereview.chromium.org/2365763002/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc:1: h 
// Copyright 2013 The Chromium Authors. All rights reserved.
Uh-oh, I think I found why the bot is broken :P

https://codereview.chromium.org/2365763002/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc:18:
using sync_integration_test_util::AwaitCommitActivityCompletion;
de-dent

https://codereview.chromium.org/2365763002/diff/1/chrome/browser/sync/test/in...
File chrome/browser/sync/test/integration/sync_test.cc (right):

https://codereview.chromium.org/2365763002/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/sync_test.cc:1024: void
SyncTest::SetEncryptionPassphrase(
Honestly I'm not even sure these methods are necessary; you can just do
GetSyncService(i)->SetEncryptionPassphrase(passphrase, type)...

[skym, 2016-09-23 17:54:10]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 17:55:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-09-23 17:55:21]

https://codereview.chromium.org/2365763002/diff/1/chrome/browser/sync/test/in...
File chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc
(right):

https://codereview.chromium.org/2365763002/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc:1: h 
// Copyright 2013 The Chromium Authors. All rights reserved.
On 2016/09/23 17:39:37, maxbogue wrote:
> Uh-oh, I think I found why the bot is broken :P

Whooops, I actually found this last night, and fixed it locally. But never
uploaded and completely forgot about it this morning. Done.

https://codereview.chromium.org/2365763002/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc:18:
using sync_integration_test_util::AwaitCommitActivityCompletion;
On 2016/09/23 17:39:37, maxbogue wrote:
> de-dent

Done.

https://codereview.chromium.org/2365763002/diff/1/chrome/browser/sync/test/in...
File chrome/browser/sync/test/integration/sync_test.cc (right):

https://codereview.chromium.org/2365763002/diff/1/chrome/browser/sync/test/in...
chrome/browser/sync/test/integration/sync_test.cc:1024: void
SyncTest::SetEncryptionPassphrase(
On 2016/09/23 17:39:37, maxbogue wrote:
> Honestly I'm not even sure these methods are necessary; you can just do
> GetSyncService(i)->SetEncryptionPassphrase(passphrase, type)...

Done.

I was thinking it'd make more sense once I combined these accessors with the
checkers... But I still haven't decided where I think the checkers should live.

[maxbogue, 2016-09-23 18:01:03]

lgtm; you should update the CL description/title though.

[skym, 2016-09-23 18:35:49]

Description was changed from

==========
[Sync] Moved passphrase helper methods into SyncTest, removed ((n)) pattern,
and fixed lint violations.

BUG=647875
==========

to

==========
[Sync] Removed passphrase helper methods, removed ((n))
pattern, and fixed lint violations.

BUG=647875
==========

[commit-bot: I haz the power, 2016-09-23 19:00:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 19:00:02]

Dry run: This issue passed the CQ dry run.

[skym, 2016-09-23 19:33:30]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2016-09-23 19:34:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 19:42:35]

Description was changed from

==========
[Sync] Removed passphrase helper methods, removed ((n))
pattern, and fixed lint violations.

BUG=647875
==========

to

==========
[Sync] Removed passphrase helper methods, removed ((n))
pattern, and fixed lint violations.

BUG=647875
==========

[commit-bot: I haz the power, 2016-09-23 19:42:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-23 19:44:52]

Description was changed from

==========
[Sync] Removed passphrase helper methods, removed ((n))
pattern, and fixed lint violations.

BUG=647875
==========

to

==========
[Sync] Removed passphrase helper methods, removed ((n))
pattern, and fixed lint violations.

BUG=647875

Committed: https://crrev.com/cbb25ab10573f470c79ef624c1896a3830cc185f
Cr-Commit-Position: refs/heads/master@{#420698}
==========

[commit-bot: I haz the power, 2016-09-23 19:44:53]

Patchset 3 (id:??) landed as
https://crrev.com/cbb25ab10573f470c79ef624c1896a3830cc185f
Cr-Commit-Position: refs/heads/master@{#420698}