chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc - Issue 2365763002: [Sync] Removed passphrase helper methods, removed ((n)) pattern, and fixed lint violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc

Issue 2365763002: [Sync] Removed passphrase helper methods, removed ((n)) pattern, and fixed lint violations. (Closed)

Patch Set: Removed useless pass-through accessors. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/single_client_search_engines_sync_test.cc ('k') | chrome/browser/sync/test/integration/single_client_themes_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc b/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc

index 519b15f9f477558b667dbd4d865c1502deec9e68..41a0de515ca856d0270d5ef7bb76640dfd71aee0 100644

--- a/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc

+++ b/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc

@@ -50,7 +50,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientSessionsSyncTest, Sanity) {

ScopedWindowMap old_windows;

GURL url = GURL("http://127.0.0.1/bubba");

ASSERT_TRUE(OpenTabAndGetLocalWindows(0, url, &old_windows));

- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((0))));

+ ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0)));

// Get foreign session data from client 0.

SyncedSessionVector sessions;

@@ -161,7 +161,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientSessionsSyncTest, CookieJarMismatch) {

GURL url = GURL("http://127.0.0.1/bubba");

ASSERT_TRUE(OpenTabAndGetLocalWindows(0, url, &old_windows));

TriggerSyncForModelTypes(0, syncer::ModelTypeSet(syncer::SESSIONS));

- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((0))));

+ ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0)));

// The cookie jar mismatch value will be true by default due to

// the way integration tests trigger signin (which does not involve a normal

@@ -188,7 +188,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientSessionsSyncTest, CookieJarMismatch) {

url = GURL("http://127.0.0.1/bubba2");

ASSERT_TRUE(OpenTabAndGetLocalWindows(0, url, &old_windows));

TriggerSyncForModelTypes(0, syncer::ModelTypeSet(syncer::SESSIONS));

- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((0))));

+ ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0)));

// Verify the cookie jar mismatch bool is set to false.

ASSERT_TRUE(GetFakeServer()->GetLastCommitMessage(&message));