Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc

Issue 2365763002: [Sync] Removed passphrase helper methods, removed ((n)) pattern, and fixed lint violations. (Closed)
Patch Set: Removed useless pass-through accessors. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc b/chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc
index 1aa1f90b77bb48d4b9ffd854286f427a05d4cff3..181f0a31e56fe58415d22338817ff1fbcb5f91a1 100644
--- a/chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc
+++ b/chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc
@@ -85,7 +85,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientTypedUrlsSyncTest, E2E_ENABLED(Add)) {
"http://www.add-history.google.com/%s", base::GenerateGUID().c_str()));
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
- unsigned long initial_count = GetTypedUrlsFromClient(0).size();
+ size_t initial_count = GetTypedUrlsFromClient(0).size();
// Populate one client with a URL, wait for it to sync to the other.
GURL new_url(kHistoryUrl);
@@ -173,7 +173,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientTypedUrlsSyncTest, E2E_ENABLED(AddThenDelete)) {
"http://www.add-history.google.com/%s", base::GenerateGUID().c_str()));
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
- unsigned long initial_count = GetTypedUrlsFromClient(0).size();
+ size_t initial_count = GetTypedUrlsFromClient(0).size();
// Populate one client with a URL, wait for it to sync to the other.
GURL new_url(kHistoryUrl);
@@ -209,7 +209,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientTypedUrlsSyncTest,
GURL url2(kUrl2);
AddUrlToHistory(0, url1);
AddUrlToHistory(1, url2);
- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((1))));
+ ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(1)));
// Make sure that no data was exchanged.
history::URLRows post_sync_urls = GetTypedUrlsFromClient(0);
@@ -304,7 +304,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientTypedUrlsSyncTest,
// before syncing client 0, so we have both of client 1's URLs in the sync DB
// at the time that client 0 does model association.
ASSERT_TRUE(GetClient(1)->SetupSync()) << "SetupSync() failed";
- AwaitCommitActivityCompletion(GetSyncService((1)));
+ AwaitCommitActivityCompletion(GetSyncService(1));
ASSERT_TRUE(GetClient(0)->SetupSync()) << "SetupSync() failed";
ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
@@ -476,7 +476,6 @@ IN_PROC_BROWSER_TEST_F(TwoClientTypedUrlsSyncTest,
IN_PROC_BROWSER_TEST_F(TwoClientTypedUrlsSyncTest,
SkipImportedVisits) {
-
GURL imported_url("http://imported_url.com");
GURL browsed_url("http://browsed_url.com");
GURL browsed_and_imported_url("http://browsed_and_imported_url.com");
« no previous file with comments | « chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698