[Sync] Removed passphrase helper methods, removed ((n)) pattern, and fixed lint violations.

chrome/browser/sync/test/integration/sync_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/test/integration/sync_test.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <limits>
@@ skipping 1003 matching lines @@
   return ::IsEncryptionComplete(GetClient(index)->service());
 }
 
 bool SyncTest::AwaitEncryptionComplete(int index) {
   ProfileSyncService* service = GetClient(index)->service();
   EncryptionChecker checker(service);
   checker.Wait();
   return !checker.TimedOut();
 }
 
+void SyncTest::SetEncryptionPassphrase(

[maxbogue, 2016/09/23 17:39:37]

Honestly I'm not even sure these methods are necessary; you can just do
GetSyncService(i)->SetEncryptionPassphrase(passphrase, type)...

[skym, 2016/09/23 17:55:20]

Done.

I was thinking it'd make more sense once I combined these accessors with the
checkers... But I still haven't decided where I think the checkers should live.

+    int index,
+    const std::string& passphrase,
+    ProfileSyncService::PassphraseType type) {
+  GetClient(index)->service()->SetEncryptionPassphrase(passphrase, type);
+}
+
+bool SyncTest::SetDecryptionPassphrase(int index,
+                                       const std::string& passphrase) {
+  return GetClient(index)->service()->SetDecryptionPassphrase(passphrase);
+}
+
 bool SyncTest::AwaitQuiescence() {
   return ProfileSyncServiceHarness::AwaitQuiescence(clients());
 }
 
 bool SyncTest::UsingExternalServers() {
   return server_type_ == EXTERNAL_LIVE_SERVER;
 }
 
 bool SyncTest::ServerSupportsNotificationControl() const {
   EXPECT_NE(SERVER_TYPE_UNDECIDED, server_type_);
@@ skipping 98 matching lines @@
 
 void SyncTest::TriggerSyncForModelTypes(int index,
                                         syncer::ModelTypeSet model_types) {
   GetSyncService(index)->TriggerRefresh(model_types);
 }
 
 void SyncTest::SetPreexistingPreferencesFileContents(
     const std::string& contents) {
   preexisting_preferences_file_contents_ = contents;
 }