Command buffer should not report depth_texture on pure ES3 without depth_texture extension.

Command buffer should not report depth_texture on pure ES3 without depth_texture extension.

BUG=649200
TEST=gpu bots
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a4589e6cdc603a7d597339c964f78e6f2b4f4c66
Cr-Commit-Position: refs/heads/master@{#420803}

[Zhenyao Mo, 2016-09-23 18:18:17]

Description was changed from

==========
Command buffer should not report depth_texture on pure ES3 without depth_texture
extension.

BUG=649200
TEST=gpu bots
R=kbr@chromium.org
==========

to

==========
Command buffer should not report depth_texture on pure ES3 without depth_texture
extension.

BUG=649200
TEST=gpu bots
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-09-23 18:18:17]

Description was changed from

==========
Command buffer should not report depth_texture on pure ES3 without depth_texture
extension.

BUG=649200
TEST=gpu bots
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Command buffer should not report depth_texture on pure ES3 without depth_texture
extension.

BUG=649200
TEST=gpu bots
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-09-23 18:19:29]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-09-23 18:20:05]

kbr: please review
jmadill: FYI

[commit-bot: I haz the power, 2016-09-23 18:20:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 18:44:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 18:44:41]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ken Russell (switch to Gerrit), 2016-09-23 19:25:16]

Needs to pass the gpu_unittests first.

https://codereview.chromium.org/2363773007/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager.cc (right):

https://codereview.chromium.org/2363773007/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager.cc:565: if
(sampler_state.compare_mode == GL_NONE) {
Could you explain this check? I thought we were going to look at the min/mag
filter and verify that they were NEAREST.

[Zhenyao Mo, 2016-09-23 20:05:24]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 20:06:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-09-23 20:07:49]

Patchset #2 (id:20001) has been deleted

[Zhenyao Mo, 2016-09-23 20:07:53]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 20:08:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-09-23 20:09:10]

Please review again. The unit tests are fixed.

https://codereview.chromium.org/2363773007/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager.cc (right):

https://codereview.chromium.org/2363773007/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager.cc:565: if
(sampler_state.compare_mode == GL_NONE) {
On 2016/09/23 19:25:15, Ken Russell wrote:
> Could you explain this check? I thought we were going to look at the min/mag
> filter and verify that they were NEAREST.

The filter check is done in the above (line 555-557).  The compare_mode check is
in the ES3 spec.

[Ken Russell (switch to Gerrit), 2016-09-23 20:27:09]

On 2016/09/23 20:09:10, Zhenyao Mo wrote:
> Please review again. The unit tests are fixed.
> 
>
https://codereview.chromium.org/2363773007/diff/1/gpu/command_buffer/service/...
> File gpu/command_buffer/service/texture_manager.cc (right):
> 
>
https://codereview.chromium.org/2363773007/diff/1/gpu/command_buffer/service/...
> gpu/command_buffer/service/texture_manager.cc:565: if
> (sampler_state.compare_mode == GL_NONE) {
> On 2016/09/23 19:25:15, Ken Russell wrote:
> > Could you explain this check? I thought we were going to look at the min/mag
> > filter and verify that they were NEAREST.
> 
> The filter check is done in the above (line 555-557).  The compare_mode check
is
> in the ES3 spec.

Ah. Thanks for pointing that out. LGTM

[commit-bot: I haz the power, 2016-09-23 21:41:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:41:34]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Zhenyao Mo, 2016-09-23 21:47:41]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:48:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 01:04:19]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-24 01:06:11]

Description was changed from

==========
Command buffer should not report depth_texture on pure ES3 without depth_texture
extension.

BUG=649200
TEST=gpu bots
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Command buffer should not report depth_texture on pure ES3 without depth_texture
extension.

BUG=649200
TEST=gpu bots
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a4589e6cdc603a7d597339c964f78e6f2b4f4c66
Cr-Commit-Position: refs/heads/master@{#420803}
==========

[commit-bot: I haz the power, 2016-09-24 01:06:12]

Patchset 2 (id:??) landed as
https://crrev.com/a4589e6cdc603a7d597339c964f78e6f2b4f4c66
Cr-Commit-Position: refs/heads/master@{#420803}