Command buffer should not report depth_texture on pure ES3 without depth_texture extension.

gpu/command_buffer/service/texture_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/texture_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 543 matching lines @@
   }
   if ((sampler_state.min_filter != GL_NEAREST &&
        sampler_state.min_filter != GL_NEAREST_MIPMAP_NEAREST) ||
       sampler_state.mag_filter != GL_NEAREST) {
     DCHECK(!face_infos_.empty());
     DCHECK_LT(static_cast<size_t>(base_level_),
               face_infos_[0].level_infos.size());
     const Texture::LevelInfo& first_level =
         face_infos_[0].level_infos[base_level_];
     if ((GLES2Util::GetChannelsForFormat(first_level.internal_format) &
-         (GLES2Util::kDepth | GLES2Util::kStencil)) != 0 ||
-        feature_info->validators()->compressed_texture_format.IsValid(
-            first_level.internal_format)) {
-      // TODO(zmo): The assumption that depth/stencil textures and compressed
-      // textures are all filterable may not be true in the future.
+         (GLES2Util::kDepth | GLES2Util::kStencil)) != 0) {
+      if (sampler_state.compare_mode == GL_NONE) {

[Ken Russell (switch to Gerrit), 2016/09/23 19:25:15]

Could you explain this check? I thought we were going to look at the min/mag
filter and verify that they were NEAREST.

[Zhenyao Mo, 2016/09/23 20:09:10]

The filter check is done in the above (line 555-557).  The compare_mode check is
in the ES3 spec.

+        // In ES2 with OES_depth_texture, such limitation isn't specified.
+        if (feature_info->IsES3Enabled()) {
+          return false;
+        }
+      }
+    } else if (feature_info->validators()->compressed_texture_format.IsValid(
+        first_level.internal_format)) {
+      // TODO(zmo): The assumption that compressed textures are all filterable
+      // may not be true in the future.
     } else {
       if (!Texture::TextureFilterable(feature_info,
                                       first_level.internal_format,
                                       first_level.type)) {
         return false;
       }
     }
   }
 
   if (!feature_info->IsES3Enabled()) {
@@ skipping 2839 matching lines @@
 uint32_t TextureManager::GetServiceIdGeneration() const {
   return current_service_id_generation_;
 }
 
 void TextureManager::IncrementServiceIdGeneration() {
   current_service_id_generation_++;
 }
 
 }  // namespace gles2
 }  // namespace gpu