Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: gpu/command_buffer/service/feature_info_unittest.cc

Issue 2363773007: Command buffer should not report depth_texture on pure ES3 without depth_texture extension. (Closed)
Patch Set: fix unittests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/texture_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/feature_info_unittest.cc
diff --git a/gpu/command_buffer/service/feature_info_unittest.cc b/gpu/command_buffer/service/feature_info_unittest.cc
index 821e52581d8ad79aba24c25f673dae1eb034de07..8c3d34c2fbbb36ca2d238b2942b1cbc6b3cb6b17 100644
--- a/gpu/command_buffer/service/feature_info_unittest.cc
+++ b/gpu/command_buffer/service/feature_info_unittest.cc
@@ -1435,26 +1435,26 @@ TEST_P(FeatureInfoTest, InitializeWithES3) {
EXPECT_TRUE(info_->feature_flags().use_async_readpixels);
EXPECT_TRUE(info_->feature_flags().oes_standard_derivatives);
EXPECT_TRUE(info_->feature_flags().oes_depth24);
- EXPECT_THAT(info_->extensions(), HasSubstr("GL_GOOGLE_depth_texture"));
- EXPECT_THAT(info_->extensions(), HasSubstr("GL_CHROMIUM_depth_texture"));
- EXPECT_TRUE(
+ EXPECT_THAT(info_->extensions(), Not(HasSubstr("GL_GOOGLE_depth_texture")));
+ EXPECT_THAT(info_->extensions(), Not(HasSubstr("GL_CHROMIUM_depth_texture")));
+ EXPECT_FALSE(
info_->validators()->texture_internal_format.IsValid(GL_DEPTH_COMPONENT));
- EXPECT_TRUE(
+ EXPECT_FALSE(
info_->validators()->texture_internal_format.IsValid(GL_DEPTH_STENCIL));
- EXPECT_TRUE(info_->validators()->texture_format.IsValid(GL_DEPTH_COMPONENT));
- EXPECT_TRUE(info_->validators()->texture_format.IsValid(GL_DEPTH_STENCIL));
- EXPECT_TRUE(info_->validators()->pixel_type.IsValid(GL_UNSIGNED_SHORT));
- EXPECT_TRUE(info_->validators()->pixel_type.IsValid(GL_UNSIGNED_INT));
- EXPECT_TRUE(info_->validators()->pixel_type.IsValid(GL_UNSIGNED_INT_24_8));
+ EXPECT_FALSE(info_->validators()->texture_format.IsValid(GL_DEPTH_COMPONENT));
+ EXPECT_FALSE(info_->validators()->texture_format.IsValid(GL_DEPTH_STENCIL));
+ EXPECT_FALSE(info_->validators()->pixel_type.IsValid(GL_UNSIGNED_SHORT));
+ EXPECT_FALSE(info_->validators()->pixel_type.IsValid(GL_UNSIGNED_INT));
+ EXPECT_FALSE(info_->validators()->pixel_type.IsValid(GL_UNSIGNED_INT_24_8));
EXPECT_TRUE(info_->feature_flags().packed_depth24_stencil8);
EXPECT_THAT(info_->extensions(), HasSubstr("GL_OES_depth24"));
EXPECT_TRUE(
info_->validators()->render_buffer_format.IsValid(GL_DEPTH_COMPONENT24));
EXPECT_TRUE(
info_->validators()->render_buffer_format.IsValid(GL_DEPTH24_STENCIL8));
- EXPECT_TRUE(
+ EXPECT_FALSE(
info_->validators()->texture_internal_format.IsValid(GL_DEPTH_STENCIL));
- EXPECT_TRUE(info_->validators()->texture_format.IsValid(GL_DEPTH_STENCIL));
+ EXPECT_FALSE(info_->validators()->texture_format.IsValid(GL_DEPTH_STENCIL));
EXPECT_TRUE(info_->feature_flags().npot_ok);
EXPECT_TRUE(info_->feature_flags().native_vertex_array_object);
EXPECT_TRUE(info_->feature_flags().enable_samplers);
@@ -1465,6 +1465,26 @@ TEST_P(FeatureInfoTest, InitializeWithES3) {
EXPECT_TRUE(gl::GLFence::IsSupported());
}
+TEST_P(FeatureInfoTest, InitializeWithES3AndDepthTexture) {
+ SetupInitExpectationsWithGLVersion(
+ "GL_ANGLE_depth_texture", "", "OpenGL ES 3.0");
+ EXPECT_THAT(info_->extensions(), HasSubstr("GL_GOOGLE_depth_texture"));
+ EXPECT_THAT(info_->extensions(), HasSubstr("GL_CHROMIUM_depth_texture"));
+ EXPECT_TRUE(
+ info_->validators()->texture_internal_format.IsValid(GL_DEPTH_COMPONENT));
+ EXPECT_TRUE(
+ info_->validators()->texture_internal_format.IsValid(GL_DEPTH_STENCIL));
+ EXPECT_TRUE(info_->validators()->texture_format.IsValid(GL_DEPTH_COMPONENT));
+ EXPECT_TRUE(info_->validators()->texture_format.IsValid(GL_DEPTH_STENCIL));
+ EXPECT_TRUE(info_->validators()->pixel_type.IsValid(GL_UNSIGNED_SHORT));
+ EXPECT_TRUE(info_->validators()->pixel_type.IsValid(GL_UNSIGNED_INT));
+ EXPECT_TRUE(info_->validators()->pixel_type.IsValid(GL_UNSIGNED_INT_24_8));
+ EXPECT_TRUE(info_->feature_flags().packed_depth24_stencil8);
+ EXPECT_TRUE(
+ info_->validators()->texture_internal_format.IsValid(GL_DEPTH_STENCIL));
+ EXPECT_TRUE(info_->validators()->texture_format.IsValid(GL_DEPTH_STENCIL));
+}
+
TEST_P(FeatureInfoTest, InitializeWithoutSamplers) {
SetupInitExpectationsWithGLVersion("", "", "3.0");
EXPECT_FALSE(info_->feature_flags().enable_samplers);
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/texture_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698