Updating isolated scripts to ignore chartjson results dir flag.

Updating isolated scripts to ignore chartjson results dir flag.

BUG=chromium:633253
Committed: https://crrev.com/2e66f3d0481cf77432d0c57adbbed76e3e3178a6
Cr-Commit-Position: refs/heads/master@{#420331}

[eyaich1, 2016-09-21 14:28:13]

eyaich@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-09-21 18:48:47]

LGTM with one question.

https://codereview.chromium.org/2358013002/diff/1/testing/scripts/run_gpu_int...
File testing/scripts/run_gpu_integration_test_as_googletest.py (right):

https://codereview.chromium.org/2358013002/diff/1/testing/scripts/run_gpu_int...
testing/scripts/run_gpu_integration_test_as_googletest.py:56: index += 1
Does this really have a different effect than the earlier code? The caller of
the script should be the one creating the file -- all the parser is doing is
opening it for writing. Unless the caller is just making a temporary file name,
and the previous code is causing it to write an empty file...

[eyaich1, 2016-09-22 13:24:50]

https://codereview.chromium.org/2358013002/diff/1/testing/scripts/run_gpu_int...
File testing/scripts/run_gpu_integration_test_as_googletest.py (right):

https://codereview.chromium.org/2358013002/diff/1/testing/scripts/run_gpu_int...
testing/scripts/run_gpu_integration_test_as_googletest.py:56: index += 1
On 2016/09/21 18:48:47, Ken Russell wrote:
> Does this really have a different effect than the earlier code? The caller of
> the script should be the one creating the file -- all the parser is doing is
> opening it for writing. Unless the caller is just making a temporary file
name,
> and the previous code is causing it to write an empty file...

Yes, the caller (the swarming api) is simply defining the file path and name
since it knows the temp bot directory, this is where the file actually gets
created.  I ran it locally to confirm that the file was created before and no
longer is.  As far as I can tell, no where in the swarming code do they actually
create the file.

[eyaich1, 2016-09-22 13:24:55]

The CQ bit was checked by eyaich@chromium.org

[commit-bot: I haz the power, 2016-09-22 13:25:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 14:21:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-22 14:24:10]

Description was changed from

==========
Updating isolated scripts to ignore chartjson results dir flag.

BUG=chromium:633253
==========

to

==========
Updating isolated scripts to ignore chartjson results dir flag.

BUG=chromium:633253

Committed: https://crrev.com/2e66f3d0481cf77432d0c57adbbed76e3e3178a6
Cr-Commit-Position: refs/heads/master@{#420331}
==========

[commit-bot: I haz the power, 2016-09-22 14:24:11]

Patchset 1 (id:??) landed as
https://crrev.com/2e66f3d0481cf77432d0c57adbbed76e3e3178a6
Cr-Commit-Position: refs/heads/master@{#420331}

[Ken Russell (switch to Gerrit), 2016-09-22 14:27:04]

https://codereview.chromium.org/2358013002/diff/1/testing/scripts/run_gpu_int...
File testing/scripts/run_gpu_integration_test_as_googletest.py (right):

https://codereview.chromium.org/2358013002/diff/1/testing/scripts/run_gpu_int...
testing/scripts/run_gpu_integration_test_as_googletest.py:56: index += 1
On 2016/09/22 13:24:50, eyaich1 wrote:
> On 2016/09/21 18:48:47, Ken Russell wrote:
> > Does this really have a different effect than the earlier code? The caller
of
> > the script should be the one creating the file -- all the parser is doing is
> > opening it for writing. Unless the caller is just making a temporary file
> name,
> > and the previous code is causing it to write an empty file...
> 
> Yes, the caller (the swarming api) is simply defining the file path and name
> since it knows the temp bot directory, this is where the file actually gets
> created.  I ran it locally to confirm that the file was created before and no
> longer is.  As far as I can tell, no where in the swarming code do they
actually
> create the file.

OK, thanks. Re-checking the recipe code I see I was wrong. Sorry about sending
you down the wrong path here.