Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: testing/scripts/run_telemetry_as_googletest.py

Issue 2358013002: Updating isolated scripts to ignore chartjson results dir flag. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: testing/scripts/run_telemetry_as_googletest.py
diff --git a/testing/scripts/run_telemetry_as_googletest.py b/testing/scripts/run_telemetry_as_googletest.py
index 71550a4181ed55b9b80beb1980fae16f1bab14b1..82491845dc6273f5cfd88b806b7eccb104583fae 100755
--- a/testing/scripts/run_telemetry_as_googletest.py
+++ b/testing/scripts/run_telemetry_as_googletest.py
@@ -37,11 +37,16 @@ def main():
parser.add_argument(
'--isolated-script-test-output', type=argparse.FileType('w'),
required=True)
- parser.add_argument(
- '--isolated-script-test-chartjson-output', type=argparse.FileType('w'),
- required=False)
parser.add_argument('--xvfb', help='Start xvfb.', action='store_true')
args, rest_args = parser.parse_known_args()
+ # Remove the chartjson extra arg until this script cares about chartjson
+ # results from telemetry
+ index = 0
+ for arg in rest_args:
+ if '--isolated-script-test-chartjson-output' in arg:
+ rest_args.pop(index)
+ break
+ index += 1
xvfb_proc = None
openbox_proc = None

Powered by Google App Engine
This is Rietveld 408576698