Updating isolated scripts to ignore chartjson results dir flag.

testing/scripts/run_gpu_integration_test_as_googletest.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs an isolate bundled Telemetry GPU integration test.
 
 This script attempts to emulate the contract of gtest-style tests
 invoked via recipes. The main contract is that the caller passes the
 argument:
@@ skipping 26 matching lines @@
 # Importing it and using its get_sandbox_env breaks test runs on Linux
 # (it seems to unset DISPLAY).
 CHROME_SANDBOX_ENV = 'CHROME_DEVEL_SANDBOX'
 CHROME_SANDBOX_PATH = '/opt/chromium/chrome_sandbox'
 
 def main():
   parser = argparse.ArgumentParser()
   parser.add_argument(
       '--isolated-script-test-output', type=str,
       required=True)
-  parser.add_argument(
-    '--isolated-script-test-chartjson-output', type=argparse.FileType('w'),
-    required=False)
   parser.add_argument('--xvfb', help='Start xvfb.', action='store_true')
   args, rest_args = parser.parse_known_args()
+  # Remove the chartjson extra arg until this script cares about chartjson
+  # results from telemetry
+  index = 0
+  for arg in rest_args:
+    if '--isolated-script-test-chartjson-output' in arg:
+      rest_args.pop(index)
+      break
+    index += 1

[Ken Russell (switch to Gerrit), 2016/09/21 18:48:47]

Does this really have a different effect than the earlier code? The caller of
the script should be the one creating the file -- all the parser is doing is
opening it for writing. Unless the caller is just making a temporary file name,
and the previous code is causing it to write an empty file...

[eyaich1, 2016/09/22 13:24:50]

Yes, the caller (the swarming api) is simply defining the file path and name
since it knows the temp bot directory, this is where the file actually gets
created.  I ran it locally to confirm that the file was created before and no
longer is.  As far as I can tell, no where in the swarming code do they actually
create the file.

[Ken Russell (switch to Gerrit), 2016/09/22 14:27:04]

OK, thanks. Re-checking the recipe code I see I was wrong. Sorry about sending
you down the wrong path here.

 
   xvfb_proc = None
   openbox_proc = None
   xcompmgr_proc = None
   env = os.environ.copy()
   # Assume we want to set up the sandbox environment variables all the
   # time; doing so is harmless on non-Linux platforms and is needed
   # all the time on Linux.
   env[CHROME_SANDBOX_ENV] = CHROME_SANDBOX_PATH
   if args.xvfb and xvfb.should_start_xvfb(env):
@@ skipping 50 matching lines @@
 
 if __name__ == '__main__':
   # Conform minimally to the protocol defined by ScriptTest.
   if 'compile_targets' in sys.argv:
     funcs = {
       'run': None,
       'compile_targets': main_compile_targets,
     }
     sys.exit(common.run_script(sys.argv[1:], funcs))
   sys.exit(main())