Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: testing/scripts/run_gpu_integration_test_as_googletest.py

Issue 2358013002: Updating isolated scripts to ignore chartjson results dir flag. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/scripts/run_telemetry_as_googletest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/scripts/run_gpu_integration_test_as_googletest.py
diff --git a/testing/scripts/run_gpu_integration_test_as_googletest.py b/testing/scripts/run_gpu_integration_test_as_googletest.py
index 955095e9be092e15c8976e8d6f74622934a8c538..fd48e06cf36e76e43993ac311afc1ebc78cd1992 100755
--- a/testing/scripts/run_gpu_integration_test_as_googletest.py
+++ b/testing/scripts/run_gpu_integration_test_as_googletest.py
@@ -44,11 +44,16 @@ def main():
parser.add_argument(
'--isolated-script-test-output', type=str,
required=True)
- parser.add_argument(
- '--isolated-script-test-chartjson-output', type=argparse.FileType('w'),
- required=False)
parser.add_argument('--xvfb', help='Start xvfb.', action='store_true')
args, rest_args = parser.parse_known_args()
+ # Remove the chartjson extra arg until this script cares about chartjson
+ # results from telemetry
+ index = 0
+ for arg in rest_args:
+ if '--isolated-script-test-chartjson-output' in arg:
+ rest_args.pop(index)
+ break
+ index += 1
Ken Russell (switch to Gerrit) 2016/09/21 18:48:47 Does this really have a different effect than the
eyaich1 2016/09/22 13:24:50 Yes, the caller (the swarming api) is simply defin
Ken Russell (switch to Gerrit) 2016/09/22 14:27:04 OK, thanks. Re-checking the recipe code I see I wa
xvfb_proc = None
openbox_proc = None
« no previous file with comments | « no previous file | testing/scripts/run_telemetry_as_googletest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698