Queue a close event for dialog.close

Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-the-dialog,
dialog should "Queue a task to fire a simple event named close at subject". So this fix
queues the close event instead of dispatching it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/dialog-close.html.

BUG=380087
TEST=Load http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/dialog-close.html
R=skobes@chromium.org

Committed: https://crrev.com/9027b8baa9ca3ada4de5e8a9efd28ee7ef476c0f
Cr-Commit-Position: refs/heads/master@{#420839}

[xing.xu, 2016-09-21 03:22:54]

Description was changed from

==========
Queue a close event for dialog.close

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
==========

to

==========
Queue a close event for dialog.close

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

[xing.xu, 2016-09-21 03:22:55]

xing.xu@intel.com changed reviewers:
+ skobes@chromium.org

[xing.xu, 2016-09-21 03:23:16]

Hi, please help to review

[skobes, 2016-09-21 17:41:00]

Can you add a layout test?

Also the spec link in the bug is broken, can you put an updated spec link in the
change description?

[xing.xu, 2016-09-23 02:23:09]

@skobes, Layout test added and description changed.

[xing.xu, 2016-09-23 14:55:42]

Description was changed from

==========
Queue a close event for dialog.close

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

to

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event.
While according to
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...
should "Queue a task to fire a simple event named close at subject".

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

[xing.xu, 2016-09-23 14:56:09]

Description was changed from

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event.
While according to
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...
should "Queue a task to fire a simple event named close at subject".

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

to

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event.
While according to
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,
dialog should "Queue a task to fire a simple event named close at subject".

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

[xing.xu, 2016-09-23 14:56:40]

Description was changed from

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event.
While according to
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,
dialog should "Queue a task to fire a simple event named close at subject".

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

to

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event.
While according to
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject".

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

[xing.xu, 2016-09-23 14:58:07]

Description was changed from

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event.
While according to
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject".

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

to

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to 
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject". So
this fix will queue the close event instead of dispatch it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

[xing.xu, 2016-09-23 14:58:31]

Description was changed from

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to 
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject". So
this fix will queue the close event instead of dispatch it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

to

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to 
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject". So
this fix queues the close event instead of dispatch it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

[xing.xu, 2016-09-23 14:58:51]

Description was changed from

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to 
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject". So
this fix queues the close event instead of dispatch it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

to

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to 
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject". So
this fix 
queues the close event instead of dispatch it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

[xing.xu, 2016-09-23 14:59:10]

Description was changed from

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to 
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject". So
this fix 
queues the close event instead of dispatch it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

to

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to 
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject". So
this fix 
queues the close event instead of dispatch it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

[xing.xu, 2016-09-23 14:59:37]

Description was changed from

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to 
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject". So
this fix 
queues the close event instead of dispatch it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

to

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to 
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject". So
this fix 
queues the close event instead of dispatching it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

[skobes, 2016-09-23 15:36:00]

Thanks.

We don't usually include the bug # in the test filename.  I'd call it something
like dialog-close-event-async.html.

[xing.xu, 2016-09-23 23:38:10]

@skobes, rename is done.

[skobes, 2016-09-23 23:45:27]

lgtm

[xing.xu, 2016-09-23 23:55:27]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2016-09-23 23:55:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 00:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 00:57:56]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xing.xu, 2016-09-24 07:31:33]

The CQ bit was checked by xing.xu@intel.com

[xing.xu, 2016-09-24 07:31:34]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2355743005/#ps80001
(title: "Queue a close event for dialog.close")

[commit-bot: I haz the power, 2016-09-24 07:31:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 08:17:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 08:17:10]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[xing.xu, 2016-09-24 09:06:55]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2016-09-24 09:06:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 09:38:57]

Description was changed from

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to 
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject". So
this fix 
queues the close event instead of dispatching it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

to

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to 
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject". So
this fix 
queues the close event instead of dispatching it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

[commit-bot: I haz the power, 2016-09-24 09:38:58]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-24 09:41:10]

Description was changed from

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to 
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,

dialog should "Queue a task to fire a simple event named close at subject". So
this fix 
queues the close event instead of dispatching it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org
==========

to

==========
Queue a close event for dialog.close

Currently dialog synchronously dispatches the close event. While according to
https://www.w3.org/TR/2013/CR-html5-20130806/interactive-elements.html#close-...,
dialog should "Queue a task to fire a simple event named close at subject". So
this fix
queues the close event instead of dispatching it immediately.

Layout test dialog-close-bug380087.html is from
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di....

BUG=380087
TEST=Load
http://w3c-test.org/html/semantics/interactive-elements/the-dialog-element/di...
R=skobes@chromium.org

Committed: https://crrev.com/9027b8baa9ca3ada4de5e8a9efd28ee7ef476c0f
Cr-Commit-Position: refs/heads/master@{#420839}
==========

[commit-bot: I haz the power, 2016-09-24 09:41:11]

Patchset 5 (id:??) landed as
https://crrev.com/9027b8baa9ca3ada4de5e8a9efd28ee7ef476c0f
Cr-Commit-Position: refs/heads/master@{#420839}