Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/submit-dialog-close-event.html

Issue 2355743005: Queue a close event for dialog.close (Closed)
Patch Set: Queue a close event for dialog.close Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/submit-dialog-close-event.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/submit-dialog-close-event.html b/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/submit-dialog-close-event.html
index ce7ee14432d43d7f74825d02179d2efb6ee5cce3..bbeb5927b41ed3c2d8d3272be9a1aa3013dba353 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/submit-dialog-close-event.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/submit-dialog-close-event.html
@@ -13,6 +13,7 @@
<script>
description('Tests submitting a dialog on a close event triggered by a previous submission.');
+window.jsTestIsAsync = true;
function testGoodbye()
{
dialog = document.querySelector('dialog');
@@ -33,14 +34,11 @@ function testHello()
dialog.addEventListener('close', function() {
shouldBeFalse('dialog.open');
shouldBeEqualToString('dialog.returnValue', 'Hello');
- if (window.testRunner)
- testRunner.notifyDone();
+ finishJSTest();
});
document.querySelector('#hello').click();
}
-if (window.testRunner)
- testRunner.waitUntilDone();
testGoodbye();
</script>
</body>

Powered by Google App Engine
This is Rietveld 408576698