third_party/WebKit/LayoutTests/imported/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt - Issue 2355743005: Queue a close event for dialog.close

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/imported/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt

Issue 2355743005: Queue a close event for dialog.close (Closed)

Patch Set: Queue a close event for dialog.close Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/submit-dialog-close-event.html ('k') | third_party/WebKit/Source/core/html/HTMLDialogElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/imported/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt

diff --git a/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt b/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt

index 98d9f33c655206706641896e22b8c3d509fbaea2..5b72fe981550e10051c9617e5b2faded692f5f43 100644

--- a/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt

+++ b/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt

@@ -1,5 +1,5 @@

This is a testharness.js-based test.

-FAIL close() fires a close event assert_true: close event should be queued expected true got false

+PASS close() fires a close event

FAIL close() on a <dialog> that doesn't have an open attribute aborts the steps Failed to execute 'close' on 'HTMLDialogElement': The element does not have an 'open' attribute, and therefore cannot be closed.

PASS close() removes the open attribute and set the returnValue to the first argument

PASS close() without argument removes the open attribute and there's no returnValue