third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-close-event.html - Issue 2355743005: Queue a close event for dialog.close

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-close-event.html

Issue 2355743005: Queue a close event for dialog.close (Closed)

Patch Set: Queue a close event for dialog.close Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/dialog/dialog-close-event-async.html ('k') | third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-close-event-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-close-event.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-close-event.html b/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-close-event.html

index 43de9d2d547fcaab3ed8385f18f83998a8643ac5..def58eae81d3b9014b3394cf7bd6f5188c5c3c31 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-close-event.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-close-event.html

@@ -33,7 +33,8 @@ dialog.close();

// Verify that preventDefault() didn't cancel closing.

shouldBeFalse('dialog.open');

-shouldBe('closedCount', '2');

+// FIXME: This should be removed.

+// shouldBe('closedCount', '2');

</script>

</body>

</html>