Ports LockLayoutManager/LockWindowState to ash/common

Ports LockLayoutManager/LockWindowState to ash/common

BUG=648676
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/c89a99035148d3d7376952b8c137b83cbc7209ef
Cr-Commit-Position: refs/heads/master@{#419838}

[sky, 2016-09-20 18:07:49]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 18:08:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-09-20 18:22:47]

https://codereview.chromium.org/2354533004/diff/1/ash/common/wm/lock_layout_m...
File ash/common/wm/lock_layout_manager.h (right):

https://codereview.chromium.org/2354533004/diff/1/ash/common/wm/lock_layout_m...
ash/common/wm/lock_layout_manager.h:53: // Overriden from WmWindowObserver:
super-nit: "Overridden" or just WmWindowObserver:

https://codereview.chromium.org/2354533004/diff/1/ash/common/wm/lock_window_s...
File ash/common/wm/lock_window_state.cc (left):

https://codereview.chromium.org/2354533004/diff/1/ash/common/wm/lock_window_s...
ash/common/wm/lock_window_state.cc:172: gfx::Rect
GetBoundsForLockWindow(aura::Window* window) {
Hooray for dead code removal!

https://codereview.chromium.org/2354533004/diff/1/ash/common/wm/lock_window_s...
File ash/common/wm/lock_window_state.cc (right):

https://codereview.chromium.org/2354533004/diff/1/ash/common/wm/lock_window_s...
ash/common/wm/lock_window_state.cc:110: std::unique_ptr<wm::WindowState::State>
old_state(
Aside: old_state is unused. Do you know if we have to do this to ignore the
return value?

https://codereview.chromium.org/2354533004/diff/1/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/2354533004/diff/1/ash/root_window_controller....
ash/root_window_controller.cc:623: lock_container->SetLayoutManager(
Does this need to happen in ash/mus/root_window_controller.cc as well? Or is
that blocked on something else?

[James Cook, 2016-09-20 18:24:24]

LGTM now that I see https://codereview.chromium.org/2352153002/

[sky, 2016-09-20 18:29:39]

The CQ bit was unchecked by sky@chromium.org

[sky, 2016-09-20 18:29:45]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-09-20 18:29:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-09-20 18:30:11]

On 2016/09/20 18:24:24, James Cook wrote:
> LGTM now that I see https://codereview.chromium.org/2352153002/

Ya, I probably should have merged them. But sometimes smaller is better:)

[commit-bot: I haz the power, 2016-09-20 19:20:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-20 19:23:56]

Description was changed from

==========
Ports LockLayoutManager/LockWindowState to ash/common

BUG=648676
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Ports LockLayoutManager/LockWindowState to ash/common

BUG=648676
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/c89a99035148d3d7376952b8c137b83cbc7209ef
Cr-Commit-Position: refs/heads/master@{#419838}
==========

[commit-bot: I haz the power, 2016-09-20 19:23:57]

Patchset 1 (id:??) landed as
https://crrev.com/c89a99035148d3d7376952b8c137b83cbc7209ef
Cr-Commit-Position: refs/heads/master@{#419838}