Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2352153002: Moves creation of LockLayoutManager to common code (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves creation of LockLayoutManager to common code BUG=648676 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/3d2675393d10a8d609925114e53f7c77757ac4b4 Cr-Commit-Position: refs/heads/master@{#419845}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M ash/common/wm_root_window_controller.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/root_window_controller.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
4 years, 3 months ago (2016-09-20 18:17:15 UTC) #1
James Cook
LGTM and I'll LGTM the other one too
4 years, 3 months ago (2016-09-20 18:24:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352153002/20001
4 years, 3 months ago (2016-09-20 19:35:49 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 20:03:17 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 20:05:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d2675393d10a8d609925114e53f7c77757ac4b4
Cr-Commit-Position: refs/heads/master@{#419845}

Powered by Google App Engine
This is Rietveld 408576698