Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2354333005: Fix call to the IssueTrackerAPI constructor (Closed)

Created:
4 years, 3 months ago by Sergiy Byelozyorov
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Fix call to the IssueTrackerAPI constructor We have removed support for codesite issue tracker and removed second constructor argument in https://codereview.chromium.org/2134193002. Also catch specific exceptions in try-catch statements. R=estaab@chromium.org, tandrii@chromium.org BUG=649023 Committed: https://chromium.googlesource.com/infra/infra/+/17c391a2262c0d5161a00a3da21db9ad10f21f8c

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Fix #

Patch Set 4 : Fix and add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M appengine/chromium_try_flakes/handlers/flake_issues.py View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M appengine/chromium_try_flakes/handlers/test/flake_issues_test.py View 1 2 3 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Sergiy Byelozyorov
4 years, 3 months ago (2016-09-23 00:37:03 UTC) #2
tandrii(chromium)
lgtm
4 years, 3 months ago (2016-09-23 00:59:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354333005/40001
4 years, 3 months ago (2016-09-23 01:09:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Infra Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/316d6e523b2c2910)
4 years, 3 months ago (2016-09-23 01:22:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354333005/60001
4 years, 3 months ago (2016-09-23 01:41:36 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 02:02:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/17c391a2262c0d5161a00a3da21db...

Powered by Google App Engine
This is Rietveld 408576698