Fix call to the IssueTrackerAPI constructor

appengine/chromium_try_flakes/handlers/test/flake_issues_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import json
 import mock
 import urllib2
 
 from google.appengine.datastore import datastore_stub_util
 from google.appengine.ext import ndb
 
 import main  # Fiddles sys.path so must come first.
 
+from apiclient.errors import HttpError
 import gae_ts_mon
 from handlers.flake_issues import ProcessIssue, CreateFlakyRun
 from model.flake import Flake, FlakyRun, FlakeOccurrence
 from model.build_run import PatchsetBuilderRuns, BuildRun
 from testing_utils import testing
 from time_functions.testing import mock_datetime_utc
 
 
 TEST_TEST_RESULTS_REPLY = json.dumps({
   'tests': {
@@ skipping 114 matching lines @@
     self.issues = {}
     self.next_issue_id = 100000
 
   def create(self, issue):
     issue.id = self.next_issue_id
     self.next_issue_id += 1
     self.issues[issue.id] = issue
     return issue
 
   def getIssue(self, issue_id):
+    if issue_id not in self.issues:
+      raise HttpError(mock.Mock(status=404), '')
     return self.issues[issue_id]
 
   def getComments(self, issue_id):
     return self.issues[issue_id].comments
 
   def update(self, issue, comment):
     self.issues[issue.id] = issue
     issue.comments.append(
         MockComment(datetime.datetime.utcnow(), 'app@ae.org', comment))
 
@@ skipping 864 matching lines @@
 
   def test_only_chromium_users_are_allowed_to_change(self):
     self.mock_current_user(user_email='someone@evil-site.com')
     self.test_app.get('/override_issue_id?key=123&issue_id=0', status=401)
 
   def test_validates_issue_id(self):
     self.test_app.get('/override_issue_id?issue_id=foobar', status=400)
     self.test_app.get('/override_issue_id?issue_id=-5', status=400)
 
   def test_checks_issue_is_on_crbug(self):
-    self.test_app.get('/override_issue_id?issue_id=200', status=400)
+    self.test_app.get('/override_issue_id?issue_id=200', status=404)
+
+  def test_returns_500_on_non_404_error_from_monorail(self):
+    self.mock_api.getIssue = mock.Mock(
+        side_effect=HttpError(mock.Mock(status=500), ''))
+    self.test_app.get('/override_issue_id?issue_id=200', status=500)
 
   def test_overrides_issue_id(self):
     issue = self.mock_api.create(MockIssue({}))
     key = Flake(name='foobar', issue_id=issue.id).put()
     self.test_app.get(
         '/override_issue_id?key=%s&issue_id=%d' % (key.urlsafe(), issue.id))
     self.assertEqual(key.get().issue_id, issue.id)
 
   def test_overrides_issue_id_with_0(self):
     key = Flake(name='foobar', issue_id=100000).put()
     self.test_app.get(
         '/override_issue_id?key=%s&issue_id=0' % key.urlsafe())
     self.assertEqual(key.get().issue_id, 0)