Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: appengine/chromium_try_flakes/handlers/flake_issues.py

Issue 2354333005: Fix call to the IssueTrackerAPI constructor (Closed)
Patch Set: Fix and add tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/chromium_try_flakes/handlers/test/flake_issues_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/chromium_try_flakes/handlers/flake_issues.py
diff --git a/appengine/chromium_try_flakes/handlers/flake_issues.py b/appengine/chromium_try_flakes/handlers/flake_issues.py
index 878160b9fb2ab679efb8270e61f8786414f2f2bb..db0e14f59be49151e9ac05e0937e58986ea6bfb9 100644
--- a/appengine/chromium_try_flakes/handlers/flake_issues.py
+++ b/appengine/chromium_try_flakes/handlers/flake_issues.py
@@ -16,6 +16,7 @@ from google.appengine.api import urlfetch
from google.appengine.api import users
from google.appengine.ext import ndb
+from apiclient.errors import HttpError
import gae_ts_mon
from issue_tracker import issue_tracker_api, issue
from model.flake import (
@@ -688,7 +689,7 @@ class OverrideIssueId(webapp2.RequestHandler):
try:
issue_id = int(self.request.get('issue_id'))
- except Exception as e:
+ except (TypeError, ValueError) as e:
self.response.set_status(400)
self.response.write('Failed to parse Issue ID as an integer.')
return
@@ -699,11 +700,13 @@ class OverrideIssueId(webapp2.RequestHandler):
return
if issue_id != 0:
+ api = issue_tracker_api.IssueTrackerAPI('chromium')
try:
- api = issue_tracker_api.IssueTrackerAPI('chromium', True)
api.getIssue(issue_id)
- except Exception as e:
- self.response.set_status(400)
+ except HttpError as e:
+ if e.resp.status != 404:
+ raise
+ self.response.set_status(404)
self.response.write(
'Failed to find issue %d on issue tracker: %s.' % (issue_id, e))
return
« no previous file with comments | « no previous file | appengine/chromium_try_flakes/handlers/test/flake_issues_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698