Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2654)

Unified Diff: appengine/chromium_try_flakes/handlers/test/flake_issues_test.py

Issue 2354333005: Fix call to the IssueTrackerAPI constructor (Closed)
Patch Set: Fix and add tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/chromium_try_flakes/handlers/flake_issues.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/chromium_try_flakes/handlers/test/flake_issues_test.py
diff --git a/appengine/chromium_try_flakes/handlers/test/flake_issues_test.py b/appengine/chromium_try_flakes/handlers/test/flake_issues_test.py
index bc4e19ee4b0922db669dcfb634c861165aa7d803..29fe10071bf8f514981ae0aa3c29b305c5111722 100644
--- a/appengine/chromium_try_flakes/handlers/test/flake_issues_test.py
+++ b/appengine/chromium_try_flakes/handlers/test/flake_issues_test.py
@@ -12,6 +12,7 @@ from google.appengine.ext import ndb
import main # Fiddles sys.path so must come first.
+from apiclient.errors import HttpError
import gae_ts_mon
from handlers.flake_issues import ProcessIssue, CreateFlakyRun
from model.flake import Flake, FlakyRun, FlakeOccurrence
@@ -146,6 +147,8 @@ class MockIssueTrackerAPI(object):
return issue
def getIssue(self, issue_id):
+ if issue_id not in self.issues:
+ raise HttpError(mock.Mock(status=404), '')
return self.issues[issue_id]
def getComments(self, issue_id):
@@ -1030,7 +1033,12 @@ class TestOverrideIssueID(testing.AppengineTestCase):
self.test_app.get('/override_issue_id?issue_id=-5', status=400)
def test_checks_issue_is_on_crbug(self):
- self.test_app.get('/override_issue_id?issue_id=200', status=400)
+ self.test_app.get('/override_issue_id?issue_id=200', status=404)
+
+ def test_returns_500_on_non_404_error_from_monorail(self):
+ self.mock_api.getIssue = mock.Mock(
+ side_effect=HttpError(mock.Mock(status=500), ''))
+ self.test_app.get('/override_issue_id?issue_id=200', status=500)
def test_overrides_issue_id(self):
issue = self.mock_api.create(MockIssue({}))
« no previous file with comments | « appengine/chromium_try_flakes/handlers/flake_issues.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698