cc: Make most of cc::OutputSurface abstract.

cc: Make most of cc::OutputSurface abstract.

This makes most methods on cc::OutputSurface abstract getting
us closer to this being an interface again. Currently we have
many levels of classes overriding and changing behaviour of
methods, and since the base class is an implementation you
have at least two. This changes most methods to be pure
virtual which forces all implementations of the class to
consider if they should be doing something in these methods.
A surprising number of methods are not used except in single-
platform scenarios, which leads to questions if this API is
optimal, but it's nice to expose the situtation as these
methods already existed but were sometimes (rarely)
overridden. Also eliminates some swap-buffers-complete
dancing through multiple levels of inheritance just to
call the client's DidSwapBuffersComplete().

TBR=nyquist
R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/1c77b832a90d6aab18e5b3ec91dd43291a3f57a7
Cr-Commit-Position: refs/heads/master@{#420994}

[danakj, 2016-09-20 01:45:59]

Description was changed from

==========
outputsurface-cleanup:

R=enne@chromium.org
BUG=
==========

to

==========
outputsurface-cleanup:

R=enne@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-20 01:46:20]

Description was changed from

==========
outputsurface-cleanup:

R=enne@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
outputsurface-cleanup:

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-20 01:46:25]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 01:46:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 02:00:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 02:00:54]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[danakj, 2016-09-22 00:16:01]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 00:16:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 01:06:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 01:06:05]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-09-23 00:42:05]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 00:42:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 01:37:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 01:37:54]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-09-23 23:56:15]

Description was changed from

==========
outputsurface-cleanup:

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Make most of cc::OutputSurface abstract.

This makes most methods on cc::OutputSurface abstract getting
us closer to this being an interface again. Currently we have
many levels of classes overriding and changing behaviour of
methods, and since the base class is an implementation you
have at least two. This changes most methods to be pure
virtual which forces all implementations of the class to
consider if they should be doing something in these methods.
A surprising number of methods are not used except in single-
platform scenarios, which leads to questions if this API is
optimal, but it's nice to expose the situtation as these
methods already existed but were sometimes (rarely)
overridden. Also eliminates some swap-buffers-complete
dancing through multiple levels of inheritance just to
call the client's DidSwapBuffersComplete().

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-23 23:56:52]

Getting rid of the getters on the class and making Reshape abstract is getting
hairy so I thought I better publish where I'm at.

[danakj, 2016-09-24 00:14:50]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-24 00:15:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2016-09-24 00:52:34]

lgtm

I think it makes sense to stage this a little bit at a time.

https://codereview.chromium.org/2352963002/diff/60001/cc/output/output_surfac...
File cc/output/output_surface.cc (left):

https://codereview.chromium.org/2352963002/diff/60001/cc/output/output_surfac...
cc/output/output_surface.cc:190: if (software_device_)
Seeing all these conditionals get moved to child classes is really nice.

[danakj, 2016-09-24 01:21:41]

danakj@chromium.org changed reviewers:
+ boliu@chromium.org, nyquist@chromium.org

[danakj, 2016-09-24 01:22:11]

danakj@chromium.org changed reviewers:
+ sky@chromium.org

[danakj, 2016-09-24 01:22:12]

+boliu for content/ and webview
+nyquist for blimp/
+sky for service

[commit-bot: I haz the power, 2016-09-24 01:26:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 01:26:59]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sky, 2016-09-26 15:24:25]

sky@chromium.org changed reviewers:
+ fsamuel@chromium.org
- sky@chromium.org

[sky, 2016-09-26 15:24:26]

sky->fsamuel

[boliu, 2016-09-26 17:14:51]

lgtm

https://codereview.chromium.org/2352963002/diff/60001/content/browser/composi...
File
content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
(right):

https://codereview.chromium.org/2352963002/diff/60001/content/browser/composi...
content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc:111:
buffer_queue_->PageFlipComplete();
copy the DCHECK from old code too?

[Fady Samuel, 2016-09-26 17:16:19]

lgtm

[danakj, 2016-09-26 18:54:44]

https://codereview.chromium.org/2352963002/diff/60001/content/browser/composi...
File
content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
(right):

https://codereview.chromium.org/2352963002/diff/60001/content/browser/composi...
content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc:111:
buffer_queue_->PageFlipComplete();
On 2016/09/26 17:14:50, boliu wrote:
> copy the DCHECK from old code too?

I'm not sure what value it is TBH. We set this member in the constructor and it
never changes.

[danakj, 2016-09-26 18:55:02]

Description was changed from

==========
cc: Make most of cc::OutputSurface abstract.

This makes most methods on cc::OutputSurface abstract getting
us closer to this being an interface again. Currently we have
many levels of classes overriding and changing behaviour of
methods, and since the base class is an implementation you
have at least two. This changes most methods to be pure
virtual which forces all implementations of the class to
consider if they should be doing something in these methods.
A surprising number of methods are not used except in single-
platform scenarios, which leads to questions if this API is
optimal, but it's nice to expose the situtation as these
methods already existed but were sometimes (rarely)
overridden. Also eliminates some swap-buffers-complete
dancing through multiple levels of inheritance just to
call the client's DidSwapBuffersComplete().

R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Make most of cc::OutputSurface abstract.

This makes most methods on cc::OutputSurface abstract getting
us closer to this being an interface again. Currently we have
many levels of classes overriding and changing behaviour of
methods, and since the base class is an implementation you
have at least two. This changes most methods to be pure
virtual which forces all implementations of the class to
consider if they should be doing something in these methods.
A surprising number of methods are not used except in single-
platform scenarios, which leads to questions if this API is
optimal, but it's nice to expose the situtation as these
methods already existed but were sometimes (rarely)
overridden. Also eliminates some swap-buffers-complete
dancing through multiple levels of inheritance just to
call the client's DidSwapBuffersComplete().

TBR=nyquist
R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-26 18:55:10]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-09-26 18:56:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 19:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 19:00:38]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2016-09-26 19:56:39]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-09-26 19:56:40]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org,
boliu@chromium.org, fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2352963002/#ps80001
(title: "outputsurface-cleanup: rebase")

[commit-bot: I haz the power, 2016-09-26 19:57:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nyquist, 2016-09-26 20:49:01]

blimp lgtm

[commit-bot: I haz the power, 2016-09-26 21:26:32]

Description was changed from

==========
cc: Make most of cc::OutputSurface abstract.

This makes most methods on cc::OutputSurface abstract getting
us closer to this being an interface again. Currently we have
many levels of classes overriding and changing behaviour of
methods, and since the base class is an implementation you
have at least two. This changes most methods to be pure
virtual which forces all implementations of the class to
consider if they should be doing something in these methods.
A surprising number of methods are not used except in single-
platform scenarios, which leads to questions if this API is
optimal, but it's nice to expose the situtation as these
methods already existed but were sometimes (rarely)
overridden. Also eliminates some swap-buffers-complete
dancing through multiple levels of inheritance just to
call the client's DidSwapBuffersComplete().

TBR=nyquist
R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Make most of cc::OutputSurface abstract.

This makes most methods on cc::OutputSurface abstract getting
us closer to this being an interface again. Currently we have
many levels of classes overriding and changing behaviour of
methods, and since the base class is an implementation you
have at least two. This changes most methods to be pure
virtual which forces all implementations of the class to
consider if they should be doing something in these methods.
A surprising number of methods are not used except in single-
platform scenarios, which leads to questions if this API is
optimal, but it's nice to expose the situtation as these
methods already existed but were sometimes (rarely)
overridden. Also eliminates some swap-buffers-complete
dancing through multiple levels of inheritance just to
call the client's DidSwapBuffersComplete().

TBR=nyquist
R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-26 21:26:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-26 21:28:52]

Description was changed from

==========
cc: Make most of cc::OutputSurface abstract.

This makes most methods on cc::OutputSurface abstract getting
us closer to this being an interface again. Currently we have
many levels of classes overriding and changing behaviour of
methods, and since the base class is an implementation you
have at least two. This changes most methods to be pure
virtual which forces all implementations of the class to
consider if they should be doing something in these methods.
A surprising number of methods are not used except in single-
platform scenarios, which leads to questions if this API is
optimal, but it's nice to expose the situtation as these
methods already existed but were sometimes (rarely)
overridden. Also eliminates some swap-buffers-complete
dancing through multiple levels of inheritance just to
call the client's DidSwapBuffersComplete().

TBR=nyquist
R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Make most of cc::OutputSurface abstract.

This makes most methods on cc::OutputSurface abstract getting
us closer to this being an interface again. Currently we have
many levels of classes overriding and changing behaviour of
methods, and since the base class is an implementation you
have at least two. This changes most methods to be pure
virtual which forces all implementations of the class to
consider if they should be doing something in these methods.
A surprising number of methods are not used except in single-
platform scenarios, which leads to questions if this API is
optimal, but it's nice to expose the situtation as these
methods already existed but were sometimes (rarely)
overridden. Also eliminates some swap-buffers-complete
dancing through multiple levels of inheritance just to
call the client's DidSwapBuffersComplete().

TBR=nyquist
R=enne@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/1c77b832a90d6aab18e5b3ec91dd43291a3f57a7
Cr-Commit-Position: refs/heads/master@{#420994}
==========

[commit-bot: I haz the power, 2016-09-26 21:28:54]

Patchset 5 (id:??) landed as
https://crrev.com/1c77b832a90d6aab18e5b3ec91dd43291a3f57a7
Cr-Commit-Position: refs/heads/master@{#420994}