Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: blimp/client/support/compositor/blimp_embedder_compositor.cc

Issue 2352963002: cc: Make most of cc::OutputSurface abstract. (Closed)
Patch Set: outputsurface-cleanup: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/parent_output_surface.cc ('k') | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/support/compositor/blimp_embedder_compositor.cc
diff --git a/blimp/client/support/compositor/blimp_embedder_compositor.cc b/blimp/client/support/compositor/blimp_embedder_compositor.cc
index d4708a43f451b83cb3894266b5483ec55cf7a4d3..c0a95d4a49944a6a60238c9de22d0ada13ab486d 100644
--- a/blimp/client/support/compositor/blimp_embedder_compositor.cc
+++ b/blimp/client/support/compositor/blimp_embedder_compositor.cc
@@ -47,17 +47,31 @@ class DisplayOutputSurface : public cc::OutputSurface {
~DisplayOutputSurface() override = default;
// cc::OutputSurface implementation
+ void EnsureBackbuffer() override {}
+ void DiscardBackbuffer() override {
+ context_provider()->ContextGL()->DiscardBackbufferCHROMIUM();
+ }
+ void BindFramebuffer() override {
+ context_provider()->ContextGL()->BindFramebuffer(GL_FRAMEBUFFER, 0);
+ }
void SwapBuffers(cc::CompositorFrame frame) override {
// See cc::OutputSurface::SwapBuffers() comment for details.
context_provider_->ContextSupport()->Swap();
cc::OutputSurface::PostSwapBuffersComplete();
}
-
+ cc::OverlayCandidateValidator* GetOverlayCandidateValidator() const override {
+ return nullptr;
+ }
+ bool IsDisplayedAsOverlayPlane() const override { return false; }
+ unsigned GetOverlayTextureId() const override { return 0; }
+ bool SurfaceIsSuspendForRecycle() const override { return false; }
uint32_t GetFramebufferCopyTextureFormat() override {
// We assume we have an alpha channel from the BlimpContextProvider, so use
// GL_RGBA here.
return GL_RGBA;
}
+ bool HasExternalStencilTest() const override { return false; }
+ void ApplyExternalStencil() override {}
private:
DISALLOW_COPY_AND_ASSIGN(DisplayOutputSurface);
« no previous file with comments | « android_webview/browser/parent_output_surface.cc ('k') | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698