Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 2352963002: cc: Make most of cc::OutputSurface abstract. (Closed)
Patch Set: outputsurface-cleanup: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/compositor_impl_android.cc
diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc
index 68ad85967f11f89cd566bbd3496f778b60f3f3f7..2cc5175e4e4ce49619b018643bea8d6082c5a3c4 100644
--- a/content/browser/renderer_host/compositor_impl_android.cc
+++ b/content/browser/renderer_host/compositor_impl_android.cc
@@ -254,10 +254,26 @@ class AndroidOutputSurface : public cc::OutputSurface {
return true;
}
+ void EnsureBackbuffer() override {}
+
+ void DiscardBackbuffer() override {
+ context_provider()->ContextGL()->DiscardBackbufferCHROMIUM();
+ }
+
+ void BindFramebuffer() override {
+ context_provider()->ContextGL()->BindFramebuffer(GL_FRAMEBUFFER, 0);
+ }
+
cc::OverlayCandidateValidator* GetOverlayCandidateValidator() const override {
return overlay_candidate_validator_.get();
}
+ bool IsDisplayedAsOverlayPlane() const override { return false; }
+ unsigned GetOverlayTextureId() const override { return 0; }
+ bool SurfaceIsSuspendForRecycle() const override { return false; }
+ bool HasExternalStencilTest() const override { return false; }
+ void ApplyExternalStencil() override {}
+
uint32_t GetFramebufferCopyTextureFormat() override {
auto* gl = static_cast<ContextProviderCommandBuffer*>(context_provider());
return gl->GetCopyTextureInternalFormat();
@@ -279,7 +295,7 @@ class AndroidOutputSurface : public cc::OutputSurface {
gfx::SwapResult result,
const gpu::GpuProcessHostedCALayerTreeParamsMac* params_mac) {
RenderWidgetHostImpl::CompositorFrameDrawn(latency_info);
- OutputSurface::OnSwapBuffersComplete();
+ client_->DidSwapBuffersComplete();
}
private:

Powered by Google App Engine
This is Rietveld 408576698