Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2464)

Unified Diff: content/renderer/android/synchronous_compositor_frame_sink.cc

Issue 2352963002: cc: Make most of cc::OutputSurface abstract. (Closed)
Patch Set: outputsurface-cleanup: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/android/synchronous_compositor_frame_sink.cc
diff --git a/content/renderer/android/synchronous_compositor_frame_sink.cc b/content/renderer/android/synchronous_compositor_frame_sink.cc
index 3656c53e2f8a51dca6c7ae45c31ccb6f5fb955dc..3ba0cf799f49e73070c197c8a1c2952feb08871a 100644
--- a/content/renderer/android/synchronous_compositor_frame_sink.cc
+++ b/content/renderer/android/synchronous_compositor_frame_sink.cc
@@ -78,7 +78,9 @@ class SynchronousCompositorFrameSink::SoftwareOutputSurface
: cc::OutputSurface(std::move(software_device)) {}
// cc::OutputSurface implementation.
- uint32_t GetFramebufferCopyTextureFormat() override { return 0; }
+ void EnsureBackbuffer() override {}
+ void DiscardBackbuffer() override {}
+ void BindFramebuffer() override {}
void SwapBuffers(cc::CompositorFrame frame) override {}
void Reshape(const gfx::Size& size,
float scale_factor,
@@ -86,6 +88,15 @@ class SynchronousCompositorFrameSink::SoftwareOutputSurface
bool has_alpha) override {
// Intentional no-op. Surface size controlled by embedder.
}
+ uint32_t GetFramebufferCopyTextureFormat() override { return 0; }
+ cc::OverlayCandidateValidator* GetOverlayCandidateValidator() const override {
+ return nullptr;
+ }
+ bool IsDisplayedAsOverlayPlane() const override { return false; }
+ unsigned GetOverlayTextureId() const override { return 0; }
+ bool SurfaceIsSuspendForRecycle() const override { return false; }
+ bool HasExternalStencilTest() const override { return false; }
+ void ApplyExternalStencil() override {}
void SetSurfaceSize(const gfx::Size surface_size) {
surface_size_ = surface_size;
« no previous file with comments | « content/browser/renderer_host/compositor_impl_android.cc ('k') | services/ui/surfaces/direct_output_surface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698