Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2352203002: [Bisect] Account for tir_label-level summaries in parse_metric (Closed)

Created:
4 years, 3 months ago by eakuefner
Modified:
4 years, 3 months ago
Reviewers:
RobertoCN, dtu, prasadv
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, sullivan
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Bisect] Account for tir_label-level summaries in parse_metric This should fix bisects for PCv2, which are broken for tir_label summaries, which we didn't used to output. BUG=644865 Committed: https://chromium.googlesource.com/chromium/tools/build/+/cee7475ca3ab8eba9c9760cdf086cc7c703df15c

Patch Set 1 #

Patch Set 2 : fix config_validation #

Patch Set 3 : fix typo ~_~ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/config_validation.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/config_validation_test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/bisect_tester/parse_metric.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
eakuefner
Prasad, Roberto, Dave: would appreciate an lgtm from any of you on this. It's meant ...
4 years, 3 months ago (2016-09-20 21:25:25 UTC) #2
RobertoCN
On 2016/09/20 21:25:25, eakuefner wrote: > Prasad, Roberto, Dave: would appreciate an lgtm from any ...
4 years, 3 months ago (2016-09-20 21:39:02 UTC) #3
eakuefner
The bug was a typo ~_~
4 years, 3 months ago (2016-09-20 22:05:57 UTC) #4
RobertoCN
lgtm
4 years, 3 months ago (2016-09-20 22:14:07 UTC) #5
eakuefner
\o/
4 years, 3 months ago (2016-09-20 22:21:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352203002/40001
4 years, 3 months ago (2016-09-20 22:21:18 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 22:25:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/cee7475ca3ab8eba9c97...

Powered by Google App Engine
This is Rietveld 408576698