Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2326723002: [Dashboard] Simplify GuessMetric (Closed)

Created:
4 years, 3 months ago by eakuefner
Modified:
4 years, 3 months ago
Reviewers:
RobertoCN
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Dashboard] Simplify GuessMetric This CL simplifies GuessMetric to pass 2- and 3-part metric names directly through to bisect. This will allow bisect to work with IR-level summaries. A followup patch will remove GuessMetric completely after bisect has been tweaked to allow 1-part metric names. BUG=catapult:#2778 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e979fa345e7ebea086d699c6940f5c6d3209eca1

Patch Set 1 #

Patch Set 2 : Fix bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -42 lines) Patch
M dashboard/dashboard/start_try_job.py View 1 2 chunks +6 lines, -34 lines 0 comments Download
M dashboard/dashboard/start_try_job_test.py View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
eakuefner
Please, take a look.
4 years, 3 months ago (2016-09-08 19:49:18 UTC) #2
RobertoCN
Looks good to me. Thanks!
4 years, 3 months ago (2016-09-08 21:24:28 UTC) #3
RobertoCN
On 2016/09/08 21:24:28, RobertoCN wrote: > Looks good to me. Thanks! LGTM FTW
4 years, 3 months ago (2016-09-08 21:24:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326723002/1
4 years, 3 months ago (2016-09-08 21:27:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Mac%20Tryserver/builds/4820)
4 years, 3 months ago (2016-09-08 21:36:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326723002/20001
4 years, 3 months ago (2016-09-20 23:29:48 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 23:52:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698