Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: scripts/slave/recipe_modules/bisect_tester/parse_metric.py

Issue 2352203002: [Bisect] Account for tir_label-level summaries in parse_metric (Closed)
Patch Set: fix typo ~_~ Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/config_validation_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/bisect_tester/parse_metric.py
diff --git a/scripts/slave/recipe_modules/bisect_tester/parse_metric.py b/scripts/slave/recipe_modules/bisect_tester/parse_metric.py
index b7bcbe01eda7d36066eb8012bfba47e683bd9e53..1b2f0b05800b9b1e4df519263a09564d7312ccae 100644
--- a/scripts/slave/recipe_modules/bisect_tester/parse_metric.py
+++ b/scripts/slave/recipe_modules/bisect_tester/parse_metric.py
@@ -57,6 +57,14 @@ def parse_chartjson_metric(results, metric): # pragma: no cover
if escape_chars(trace) == trace_name:
trace_name = trace # Unescaping
break
+
+ # This can happen if trace_name is meant to be a tir_label. This workaround
+ # is necessary because test paths are ambiguous, such that a 2-part test
+ # name can represent a tir_label-level summary or a story-level summary.
+ if trace_name not in results['charts'].get(chart_name, {}):
+ chart_name = trace_name + '@@' + chart_name
+ trace_name = 'summary'
+
if (results['charts'][chart_name][trace_name]['type'] ==
'list_of_scalar_values'):
values = results['charts'][chart_name][trace_name]['values']
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/config_validation_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698