scripts/slave/recipe_modules/auto_bisect/config_validation.py - Issue 2352203002: [Bisect] Account for tir_label-level summaries in parse_metric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/auto_bisect/config_validation.py

Issue 2352203002: [Bisect] Account for tir_label-level summaries in parse_metric (Closed)

Patch Set: fix typo ~_~ Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/auto_bisect/config_validation.py

diff --git a/scripts/slave/recipe_modules/auto_bisect/config_validation.py b/scripts/slave/recipe_modules/auto_bisect/config_validation.py

index 4681b9d7de40901c2ad5b611943251b194f17702..90ddbda4a12978722c37b5630cfdae6ef5ca299e 100644

--- a/scripts/slave/recipe_modules/auto_bisect/config_validation.py

+++ b/scripts/slave/recipe_modules/auto_bisect/config_validation.py

@@ -106,5 +106,6 @@ def _validate_revisions(good_revision, bad_revision): # pragma: no cover

def _validate_metric(bisect_mode, metric): # pragma: no cover

if bisect_mode not in ('mean', 'std_dev'):

return

- if not (isinstance(metric, basestring) and metric.count('/') == 1):

+ if not (isinstance(metric, basestring) and ((metric.count('/') == 1) or

+ (metric.count('/') == 2))):

raise ValidationFail('Invalid value for "metric": %s' % metric)

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/config_validation_test.py » ('j') | no next file with comments »