Document* -> Document& for loadSubimages and friends.

Document* -> Document& for loadSubimages and friends.

Document* should never be nullptr in these places. Also made them const
and propagated the const-ness where necessary.

R=sashab@chromium.org

Committed: https://crrev.com/0fccab70551979737eed882ec677337ede6f438e
Cr-Commit-Position: refs/heads/master@{#420319}

[rune, 2016-09-21 08:48:32]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 08:48:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2016-09-21 08:48:46]

ptal

[commit-bot: I haz the power, 2016-09-21 10:14:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 10:14:22]

Dry run: This issue passed the CQ dry run.

[sashab, 2016-09-22 00:24:32]

Yayyy less pointers more references!!! :D

Same comment as before -- how many of these could be const Document&? (happy for
follow-up patch for this)

Other than that lgtm.

https://codereview.chromium.org/2352193004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/StyleFetchedImage.cpp (right):

https://codereview.chromium.org/2352193004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/StyleFetchedImage.cpp:36: ,
m_document(&document)
Can this be Document&? :)

[rune, 2016-09-22 08:10:02]

On 2016/09/22 at 00:24:32, sashab wrote:
> Yayyy less pointers more references!!! :D
> 
> Same comment as before -- how many of these could be const Document&? (happy
for follow-up patch for this)
> 
> Other than that lgtm.
> 
>
https://codereview.chromium.org/2352193004/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/style/StyleFetchedImage.cpp (right):
> 
>
https://codereview.chromium.org/2352193004/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/style/StyleFetchedImage.cpp:36: ,
m_document(&document)
> Can this be Document&? :)

Constified it.

[rune, 2016-09-22 08:13:20]

Description was changed from

==========
Document* -> Document& for loadSubimages and friends.

Document* should never be nullptr in these places.

R=sashab@chromium.org
==========

to

==========
Document* -> Document& for loadSubimages and friends.

Document* should never be nullptr in these places. Also made them const
and propagated the const-ness where necessary.

R=sashab@chromium.org
==========

[rune, 2016-09-22 09:37:13]

The CQ bit was checked by rune@opera.com

[rune, 2016-09-22 09:37:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2352193004/#ps20001
(title: "Added constness")

[commit-bot: I haz the power, 2016-09-22 09:37:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 13:27:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-22 13:28:45]

Description was changed from

==========
Document* -> Document& for loadSubimages and friends.

Document* should never be nullptr in these places. Also made them const
and propagated the const-ness where necessary.

R=sashab@chromium.org
==========

to

==========
Document* -> Document& for loadSubimages and friends.

Document* should never be nullptr in these places. Also made them const
and propagated the const-ness where necessary.

R=sashab@chromium.org

Committed: https://crrev.com/0fccab70551979737eed882ec677337ede6f438e
Cr-Commit-Position: refs/heads/master@{#420319}
==========

[commit-bot: I haz the power, 2016-09-22 13:28:46]

Patchset 2 (id:??) landed as
https://crrev.com/0fccab70551979737eed882ec677337ede6f438e
Cr-Commit-Position: refs/heads/master@{#420319}

[sashab, 2016-09-23 00:17:05]

YYayy, nice work!! :)

Probably could have updated the CL description to say 'const Document&', but not
important :)