Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: third_party/WebKit/Source/core/css/CSSImageValue.cpp

Issue 2352193004: Document* -> Document& for loadSubimages and friends. (Closed)
Patch Set: Added constness Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSImageValue.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSImageValue.cpp b/third_party/WebKit/Source/core/css/CSSImageValue.cpp
index 1fcf9aa859d5e9799847960d0ee452137a001297..c5cfd45d6d2a75e42f7e35a6e23fae10d6c4ddda 100644
--- a/third_party/WebKit/Source/core/css/CSSImageValue.cpp
+++ b/third_party/WebKit/Source/core/css/CSSImageValue.cpp
@@ -54,18 +54,16 @@ CSSImageValue::~CSSImageValue()
{
}
-StyleImage* CSSImageValue::cacheImage(Document* document, CrossOriginAttributeValue crossOrigin)
+StyleImage* CSSImageValue::cacheImage(const Document& document, CrossOriginAttributeValue crossOrigin)
{
- ASSERT(document);
-
if (!m_cachedImage) {
FetchRequest request(ResourceRequest(m_absoluteURL), m_initiatorName.isEmpty() ? FetchInitiatorTypeNames::css : m_initiatorName);
request.mutableResourceRequest().setHTTPReferrer(SecurityPolicy::generateReferrer(m_referrer.referrerPolicy, request.url(), m_referrer.referrer));
if (crossOrigin != CrossOriginAttributeNotSet)
- request.setCrossOriginAccessControl(document->getSecurityOrigin(), crossOrigin);
+ request.setCrossOriginAccessControl(document.getSecurityOrigin(), crossOrigin);
- if (ImageResource* cachedImage = ImageResource::fetch(request, document->fetcher()))
+ if (ImageResource* cachedImage = ImageResource::fetch(request, document.fetcher()))
m_cachedImage = StyleFetchedImage::create(cachedImage, document, request.url());
else
m_cachedImage = StyleInvalidImage::create(url());
@@ -74,7 +72,7 @@ StyleImage* CSSImageValue::cacheImage(Document* document, CrossOriginAttributeVa
return m_cachedImage.get();
}
-void CSSImageValue::restoreCachedResourceIfNeeded(Document& document) const
+void CSSImageValue::restoreCachedResourceIfNeeded(const Document& document) const
{
if (!m_cachedImage || !document.fetcher() || m_absoluteURL.isNull())
return;
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSImageValue.h ('k') | third_party/WebKit/Source/core/css/CSSPaintValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698