third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp - Issue 2352193004: Document* -> Document& for loadSubimages and friends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp

Issue 2352193004: Document* -> Document& for loadSubimages and friends. (Closed)

Patch Set: Added constness Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp b/third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp

index b978d473a7f29c5f4558e4cb9688237b37233f57..aa4a2808cb3a7c84f44585e6b99d58d58e3c3c0a 100644

--- a/third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp

+++ b/third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp

@@ -93,8 +93,7 @@ TEST_F(CSSStyleSheetResourceTest, PruneCanCauseEviction)

contents->parserAppendRule(

StyleRule::create(CSSSelectorList::adoptSelectorVector(selectors), ImmutableStylePropertySet::create(&property, 1, HTMLStandardMode)));

- // TODO(rune@opera.com): loadSubimages should take Document&.

- crossfade->loadSubimages(&document());

+ crossfade->loadSubimages(document());

Resource* imageResource = memoryCache()->resourceForURL(imageURL, MemoryCache::defaultCacheIdentifier());

ASSERT_TRUE(imageResource);

ResourceResponse imageResponse;