Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSImageGeneratorValue.h

Issue 2352193004: Document* -> Document& for loadSubimages and friends. (Closed)
Patch Set: Added constness Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 void addClient(const LayoutObject*, const IntSize&); 61 void addClient(const LayoutObject*, const IntSize&);
62 void removeClient(const LayoutObject*); 62 void removeClient(const LayoutObject*);
63 PassRefPtr<Image> image(const LayoutObject&, const IntSize&, float zoom); 63 PassRefPtr<Image> image(const LayoutObject&, const IntSize&, float zoom);
64 64
65 bool isFixedSize() const; 65 bool isFixedSize() const;
66 IntSize fixedSize(const LayoutObject&, const FloatSize& defaultObjectSize); 66 IntSize fixedSize(const LayoutObject&, const FloatSize& defaultObjectSize);
67 67
68 bool isPending() const; 68 bool isPending() const;
69 bool knownToBeOpaque(const LayoutObject&) const; 69 bool knownToBeOpaque(const LayoutObject&) const;
70 70
71 void loadSubimages(Document*); 71 void loadSubimages(const Document&);
72 72
73 CSSImageGeneratorValue* valueWithURLsMadeAbsolute(); 73 CSSImageGeneratorValue* valueWithURLsMadeAbsolute();
74 74
75 DEFINE_INLINE_TRACE_AFTER_DISPATCH() { CSSValue::traceAfterDispatch(visitor) ; } 75 DEFINE_INLINE_TRACE_AFTER_DISPATCH() { CSSValue::traceAfterDispatch(visitor) ; }
76 76
77 protected: 77 protected:
78 explicit CSSImageGeneratorValue(ClassType); 78 explicit CSSImageGeneratorValue(ClassType);
79 79
80 Image* getImage(const LayoutObject*, const IntSize&); 80 Image* getImage(const LayoutObject*, const IntSize&);
81 void putImage(const IntSize&, PassRefPtr<Image>); 81 void putImage(const IntSize&, PassRefPtr<Image>);
82 const LayoutObjectSizeCountMap& clients() const { return m_clients; } 82 const LayoutObjectSizeCountMap& clients() const { return m_clients; }
83 83
84 HashCountedSet<IntSize> m_sizes; // A count of how many times a given image size is in use. 84 HashCountedSet<IntSize> m_sizes; // A count of how many times a given image size is in use.
85 LayoutObjectSizeCountMap m_clients; // A map from LayoutObjects (with entry count) to image sizes. 85 LayoutObjectSizeCountMap m_clients; // A map from LayoutObjects (with entry count) to image sizes.
86 HashMap<IntSize, RefPtr<Image>> m_images; // A cache of Image objects by ima ge size. 86 HashMap<IntSize, RefPtr<Image>> m_images; // A cache of Image objects by ima ge size.
87 87
88 // TODO(Oilpan): when/if we can make the layoutObject point directly to the CSSImageGenerator value using 88 // TODO(Oilpan): when/if we can make the layoutObject point directly to the CSSImageGenerator value using
89 // a member we don't need to have this hack where we keep a persistent to th e instance as long as 89 // a member we don't need to have this hack where we keep a persistent to th e instance as long as
90 // there are clients in the LayoutObjectSizeCountMap. 90 // there are clients in the LayoutObjectSizeCountMap.
91 SelfKeepAlive<CSSImageGeneratorValue> m_keepAlive; 91 SelfKeepAlive<CSSImageGeneratorValue> m_keepAlive;
92 }; 92 };
93 93
94 DEFINE_CSS_VALUE_TYPE_CASTS(CSSImageGeneratorValue, isImageGeneratorValue()); 94 DEFINE_CSS_VALUE_TYPE_CASTS(CSSImageGeneratorValue, isImageGeneratorValue());
95 95
96 } // namespace blink 96 } // namespace blink
97 97
98 #endif // CSSImageGeneratorValue_h 98 #endif // CSSImageGeneratorValue_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSGradientValue.h ('k') | third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698