tools/perf/metrics/io.py - Issue 23512005: BrowserOptions.extra_browser_args is now a set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/io.py

Issue 23512005: BrowserOptions.extra_browser_args is now a set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: AppendExtraBrowserArgs Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/metrics/io.py

diff --git a/tools/perf/metrics/io.py b/tools/perf/metrics/io.py

index a52089d583bb4c419baca672869c0bc78bdfc5af..d0a1da6689363d547f9ac44495bd5b0bb8706f4e 100644

--- a/tools/perf/metrics/io.py

+++ b/tools/perf/metrics/io.py

@@ -9,7 +9,7 @@ class IOMetric(Metric):

@classmethod

def CustomizeBrowserOptions(cls, options):

- options.AppendExtraBrowserArg('--no-sandbox')

+ options.extra_browser_args.add('--no-sandbox')

tonyg 2013/09/05 00:26:15 Don't we want to be using AppendExtraBrowserArgs h

achuithb 2013/09/05 00:37:11 Done.

def Start(self, page, tab):

raise NotImplementedError()