Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: tools/perf/metrics/memory.py

Issue 23512005: BrowserOptions.extra_browser_args is now a set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: AppendExtraBrowserArgs Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/metrics/memory.py
diff --git a/tools/perf/metrics/memory.py b/tools/perf/metrics/memory.py
index f6831a184026837fa64702930c46d04a699cd2cb..1055cc08d3a528fcc474dc5f020568cb5a5955a8 100644
--- a/tools/perf/metrics/memory.py
+++ b/tools/perf/metrics/memory.py
@@ -36,19 +36,21 @@ class MemoryMetric(Metric):
@classmethod
def CustomizeBrowserOptions(cls, options):
- options.AppendExtraBrowserArg('--enable-stats-collection-bindings')
- options.AppendExtraBrowserArg('--enable-memory-benchmarking')
- # For a hard-coded set of Google pages (such as GMail), we produce custom
- # memory histograms (V8.Something_gmail) instead of the generic histograms
- # (V8.Something), if we detect that a renderer is only rendering this page
- # and no other pages. For this test, we need to disable histogram
- # customizing, so that we get the same generic histograms produced for all
- # pages.
- options.AppendExtraBrowserArg('--disable-histogram-customizer')
-
- # Old commandline flags used for reference builds.
- options.AppendExtraBrowserArg('--dom-automation')
- options.AppendExtraBrowserArg('--reduce-security-for-dom-automation-tests')
+ options.AppendExtraBrowserArgs([
+ '--enable-stats-collection-bindings',
+ '--enable-memory-benchmarking',
+ # For a hard-coded set of Google pages (such as GMail), we produce
+ # custom memory histograms (V8.Something_gmail) instead of the generic
+ # histograms (V8.Something), if we detect that a renderer is only
+ # rendering this page and no other pages. For this test, we need to
+ # disable histogram customizing, so that we get the same generic
+ # histograms produced for all pages.
+ '--disable-histogram-customizer',
+
+ # Old commandline flags used for reference builds.
+ '--dom-automation',
+ '--reduce-security-for-dom-automation-tests',
+ ])
def Start(self, page, tab):
"""Start the per-page preparation for this metric.

Powered by Google App Engine
This is Rietveld 408576698