Index: tools/telemetry/telemetry/core/browser_options.py |
diff --git a/tools/telemetry/telemetry/core/browser_options.py b/tools/telemetry/telemetry/core/browser_options.py |
index 2b2608151d186b17cc8aff200d35cdef5fcc1e29..897eb5eda7835e1606b9ceb011f7107b6edb91c7 100644 |
--- a/tools/telemetry/telemetry/core/browser_options.py |
+++ b/tools/telemetry/telemetry/core/browser_options.py |
@@ -33,7 +33,7 @@ class BrowserFinderOptions(optparse.Values): |
self.dont_override_profile = False |
self.profile_dir = None |
self.profile_type = None |
- self.extra_browser_args = [] |
+ self.extra_browser_args = set() |
tonyg
2013/09/05 00:26:15
I feel like we should change this to self._extra_b
achuithb
2013/09/05 00:37:11
Done.
|
self.extra_wpr_args = [] |
self.show_stdout = False |
self.extensions_to_load = [] |
@@ -209,12 +209,12 @@ class BrowserFinderOptions(optparse.Values): |
if self.extra_browser_args_as_string: # pylint: disable=E1101 |
tmp = shlex.split( |
self.extra_browser_args_as_string) # pylint: disable=E1101 |
- self.extra_browser_args.extend(tmp) |
+ self.extra_browser_args.update(tmp) |
delattr(self, 'extra_browser_args_as_string') |
if self.extra_wpr_args_as_string: # pylint: disable=E1101 |
tmp = shlex.split( |
self.extra_wpr_args_as_string) # pylint: disable=E1101 |
- self.extra_wpr_args.extend(tmp) |
+ self.extra_wpr_args.update(tmp) |
delattr(self, 'extra_wpr_args_as_string') |
if self.profile_type == 'default': |
self.dont_override_profile = True |
@@ -233,9 +233,11 @@ class BrowserFinderOptions(optparse.Values): |
parser.parse_args = ParseArgs |
return parser |
- def AppendExtraBrowserArg(self, arg): |
- if arg not in self.extra_browser_args: |
- self.extra_browser_args.append(arg) |
+ def AppendExtraBrowserArgs(self, args): |
+ if isinstance(args, list): |
+ self.extra_browser_args.update(args) |
+ else: |
+ self.extra_browser_args.add(args) |
def MergeDefaultValues(self, defaults): |
for k, v in defaults.__dict__.items(): |