Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2350663003: Make reading list entry movable only (Closed)

Created:
4 years, 3 months ago by gambard
Modified:
4 years, 3 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make reading list entry movable only This CL disable copy and assign for reading list entry. BUG=none Committed: https://crrev.com/0b4708756ec96cae9a3770943158d519cdeb9fec Cr-Commit-Position: refs/heads/master@{#420334}

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Remove header #

Total comments: 1

Patch Set 4 : indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -33 lines) Patch
M ios/chrome/browser/reading_list/reading_list_download_service.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_entry.h View 4 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_entry.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_entry_unittest.cc View 1 1 chunk +9 lines, -5 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_storage_unittest.mm View 1 2 3 chunks +9 lines, -6 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_unittest.cc View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
gambard
PTAL.
4 years, 3 months ago (2016-09-19 11:36:48 UTC) #2
noyau (Ping after 24h)
lgtm
4 years, 3 months ago (2016-09-19 13:58:09 UTC) #3
gambard
PTAL at the tests.
4 years, 3 months ago (2016-09-19 15:01:48 UTC) #4
noyau (Ping after 24h)
lgtm https://codereview.chromium.org/2350663003/diff/40001/ios/chrome/browser/reading_list/reading_list_model_unittest.cc File ios/chrome/browser/reading_list/reading_list_model_unittest.cc (right): https://codereview.chromium.org/2350663003/diff/40001/ios/chrome/browser/reading_list/reading_list_model_unittest.cc#newcode147 ios/chrome/browser/reading_list/reading_list_model_unittest.cc:147: model_->AddEntry(GURL("http://example.com"), "sample"); indent
4 years, 3 months ago (2016-09-19 15:33:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350663003/60001
4 years, 3 months ago (2016-09-22 14:35:32 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-22 14:43:25 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 14:44:44 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0b4708756ec96cae9a3770943158d519cdeb9fec
Cr-Commit-Position: refs/heads/master@{#420334}

Powered by Google App Engine
This is Rietveld 408576698