Make reading list entry movable only

ios/chrome/browser/reading_list/reading_list_download_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/reading_list/reading_list_download_service.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
+#include "base/memory/ptr_util.h"
 #include "ios/chrome/browser/reading_list/reading_list_entry.h"
 #include "ios/chrome/browser/reading_list/reading_list_model.h"
 
 ReadingListDownloadService::ReadingListDownloadService(
     ReadingListModel* reading_list_model,
     dom_distiller::DomDistillerService* distiller_service,
     PrefService* prefs,
     base::FilePath chrome_profile_path)
     : reading_list_model_(reading_list_model) {
   DCHECK(reading_list_model);
-  url_downloader_ = std::unique_ptr<URLDownloader>(
-      new URLDownloader(distiller_service, prefs, chrome_profile_path,
-                        base::Bind(&ReadingListDownloadService::OnDownloadEnd,
-                                   base::Unretained(this)),
-                        base::Bind(&ReadingListDownloadService::OnDeleteEnd,
-                                   base::Unretained(this))));
+  url_downloader_ = base::MakeUnique<URLDownloader>(
+      distiller_service, prefs, chrome_profile_path,
+      base::Bind(&ReadingListDownloadService::OnDownloadEnd,
+                 base::Unretained(this)),
+      base::Bind(&ReadingListDownloadService::OnDeleteEnd,
+                 base::Unretained(this)));
 }
 
 ReadingListDownloadService::~ReadingListDownloadService() {}
 
 void ReadingListDownloadService::Initialize() {
   reading_list_model_->AddObserver(this);
 }
 
 void ReadingListDownloadService::Shutdown() {
   reading_list_model_->RemoveObserver(this);
@@ skipping 30 matching lines @@
     const ReadingListModel* model,
     const ReadingListEntry& entry) {
   DCHECK_EQ(reading_list_model_, model);
   DownloadEntry(entry);
 }
 
 void ReadingListDownloadService::DownloadAllEntries() {
   DCHECK(reading_list_model_->loaded());
   size_t size = reading_list_model_->unread_size();
   for (size_t i = 0; i < size; i++) {
-    ReadingListEntry entry = reading_list_model_->GetUnreadEntryAtIndex(i);
+    const ReadingListEntry& entry =
+        reading_list_model_->GetUnreadEntryAtIndex(i);
     this->DownloadEntry(entry);
   }
   size = reading_list_model_->read_size();
   for (size_t i = 0; i < size; i++) {
-    ReadingListEntry entry = reading_list_model_->GetReadEntryAtIndex(i);
+    const ReadingListEntry& entry = reading_list_model_->GetReadEntryAtIndex(i);
     this->DownloadEntry(entry);
   }
 }
 
 void ReadingListDownloadService::DownloadEntry(const ReadingListEntry& entry) {
   DCHECK(reading_list_model_->loaded());
   if (entry.DistilledState() != ReadingListEntry::ERROR) {
     reading_list_model_->SetEntryDistilledState(entry.URL(),
                                                 ReadingListEntry::PROCESSING);
     url_downloader_->DownloadOfflineURL(entry.URL());
@@ skipping 20 matching lines @@
     reading_list_model_->SetEntryDistilledState(url,
                                                 ReadingListEntry::WILL_RETRY);
   } else if (success == URLDownloader::ERROR_PERMANENT) {
     reading_list_model_->SetEntryDistilledState(url, ReadingListEntry::ERROR);
   }
 }
 
 void ReadingListDownloadService::OnDeleteEnd(const GURL& url, bool success) {
   // Nothing to update as this is only called when deleting reading list entries
 }