ios/chrome/browser/reading_list/reading_list_model_storage_unittest.mm - Issue 2350663003: Make reading list entry movable only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/reading_list/reading_list_model_storage_unittest.mm

Issue 2350663003: Make reading list entry movable only (Closed)

Patch Set: indentation Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/reading_list/reading_list_model_impl.cc ('k') | ios/chrome/browser/reading_list/reading_list_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/reading_list/reading_list_model_storage_unittest.mm

diff --git a/ios/chrome/browser/reading_list/reading_list_model_storage_unittest.mm b/ios/chrome/browser/reading_list/reading_list_model_storage_unittest.mm

index 7b5cd8daab415a26f259a6bbcda5eff8697dd9f0..da7bbf37be07de8e46672de0beea02e331408cb6 100644

--- a/ios/chrome/browser/reading_list/reading_list_model_storage_unittest.mm

+++ b/ios/chrome/browser/reading_list/reading_list_model_storage_unittest.mm

@@ -31,8 +31,9 @@ TEST(ReadingListStorage, CheckEmpties) {

TEST(ReadingListStorage, SaveOneRead) {

NSUserDefaults* defaults = FakeNonPersistentUserDefaults();

- static const std::vector<ReadingListEntry> entries{

- ReadingListEntry(GURL("http://read.example.com"), "read title")};

+ std::vector<ReadingListEntry> entries;

+ entries.push_back(

+ ReadingListEntry(GURL("http://read.example.com"), "read title"));

{

ReadingListModelStorageDefaults storage(defaults);

@@ -51,8 +52,9 @@ TEST(ReadingListStorage, SaveOneRead) {

TEST(ReadingListStorage, SaveOneUnead) {

NSUserDefaults* defaults = FakeNonPersistentUserDefaults();

- static const std::vector<ReadingListEntry> entries{

- ReadingListEntry(GURL("http://unread.example.com"), "unread title")};

+ std::vector<ReadingListEntry> entries;

+ entries.push_back(

+ ReadingListEntry(GURL("http://unread.example.com"), "unread title"));

{

ReadingListModelStorageDefaults storage(defaults);

@@ -69,8 +71,9 @@ TEST(ReadingListStorage, SaveOneUnead) {

TEST(ReadingListStorage, SaveOneModified) {

NSUserDefaults* defaults = FakeNonPersistentUserDefaults();

- static std::vector<ReadingListEntry> entries{

- ReadingListEntry(GURL("http://unread.example.com"), "unread title")};

+ std::vector<ReadingListEntry> entries;

+ entries.push_back(

+ ReadingListEntry(GURL("http://unread.example.com"), "unread title"));

{

ReadingListModelStorageDefaults storage(defaults);

entries[0].SetDistilledURL(GURL("http://distilled.example.com"));