Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: ios/chrome/browser/reading_list/reading_list_model_unittest.cc

Issue 2350663003: Make reading list entry movable only (Closed)
Patch Set: indentation Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/reading_list/reading_list_model_storage_unittest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/reading_list/reading_list_model_unittest.cc
diff --git a/ios/chrome/browser/reading_list/reading_list_model_unittest.cc b/ios/chrome/browser/reading_list/reading_list_model_unittest.cc
index 1dc18fafc1725cf8b385f261842324c35d4463bc..2e0d022304f60cd5f9e45b9471b8cdffab16fc6f 100644
--- a/ios/chrome/browser/reading_list/reading_list_model_unittest.cc
+++ b/ios/chrome/browser/reading_list/reading_list_model_unittest.cc
@@ -128,7 +128,7 @@ TEST_F(ReadingListModelTest, EmptyLoaded) {
TEST_F(ReadingListModelTest, AddEntry) {
ClearCounts();
- const ReadingListEntry entry =
+ const ReadingListEntry& entry =
model_->AddEntry(GURL("http://example.com"), "sample");
EXPECT_EQ(GURL("http://example.com"), entry.URL());
EXPECT_EQ("sample", entry.Title());
@@ -138,14 +138,13 @@ TEST_F(ReadingListModelTest, AddEntry) {
EXPECT_EQ(0ul, model_->read_size());
EXPECT_TRUE(model_->HasUnseenEntries());
- const ReadingListEntry other_entry = model_->GetUnreadEntryAtIndex(0);
+ const ReadingListEntry& other_entry = model_->GetUnreadEntryAtIndex(0);
EXPECT_EQ(GURL("http://example.com"), other_entry.URL());
EXPECT_EQ("sample", other_entry.Title());
}
TEST_F(ReadingListModelTest, ReadEntry) {
- const ReadingListEntry entry =
- model_->AddEntry(GURL("http://example.com"), "sample");
+ model_->AddEntry(GURL("http://example.com"), "sample");
ClearCounts();
model_->MarkReadByURL(GURL("http://example.com"));
@@ -154,7 +153,7 @@ TEST_F(ReadingListModelTest, ReadEntry) {
EXPECT_EQ(1ul, model_->read_size());
EXPECT_FALSE(model_->HasUnseenEntries());
- const ReadingListEntry other_entry = model_->GetReadEntryAtIndex(0);
+ const ReadingListEntry& other_entry = model_->GetReadEntryAtIndex(0);
EXPECT_EQ(GURL("http://example.com"), other_entry.URL());
EXPECT_EQ("sample", other_entry.Title());
}
« no previous file with comments | « ios/chrome/browser/reading_list/reading_list_model_storage_unittest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698