Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2349713004: Replace key_exchange_info with key_exchange_group. (Closed)

Created:
4 years, 3 months ago by davidben
Modified:
4 years, 3 months ago
CC:
asvitkine+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, loading-reviews_chromium.org, Randy Smith (Not in Mondays)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace key_exchange_info with key_exchange_group. Narrow to key_exchange_group in net::SSLInfo. The one place where key_exchange_info remains is serialization code which sadly must filter out garbage values. This removes the DHE group size histogram which was the last consumer of the non-ECDHE values. With DHE behind a fallback and now removed, there is no need for this histogram. BUG=639421 Committed: https://crrev.com/3b00e401f7b0b6ee5ed9df06acf7d3c46b12966a Cr-Commit-Position: refs/heads/master@{#419753}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -97 lines) Patch
M content/browser/loader/resource_loader.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/ssl_status.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_info.cc View 1 7 chunks +32 lines, -11 lines 0 comments Download
M net/http/http_response_info_unittest.cc View 1 4 chunks +68 lines, -4 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_impl.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 3 chunks +7 lines, -17 lines 0 comments Download
M net/ssl/ssl_cipher_suite_names.h View 1 chunk +0 lines, -6 lines 0 comments Download
M net/ssl/ssl_cipher_suite_names.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M net/ssl/ssl_info.h View 2 chunks +3 lines, -12 lines 0 comments Download
M net/ssl/ssl_info.cc View 3 chunks +2 lines, -20 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
davidben
rsleevi: This look good? I think you had opinions on how we resolve this on ...
4 years, 3 months ago (2016-09-16 23:23:33 UTC) #4
Ryan Sleevi
LGTM % patch failures
4 years, 3 months ago (2016-09-16 23:31:05 UTC) #8
davidben
+jochen for content OWNERS +holte for histograms.xml OWNERS
4 years, 3 months ago (2016-09-19 19:03:33 UTC) #12
Steven Holte
histograms lgtm
4 years, 3 months ago (2016-09-19 19:12:37 UTC) #13
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-20 09:39:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349713004/20001
4 years, 3 months ago (2016-09-20 14:26:24 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 14:31:25 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 14:33:38 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b00e401f7b0b6ee5ed9df06acf7d3c46b12966a
Cr-Commit-Position: refs/heads/master@{#419753}

Powered by Google App Engine
This is Rietveld 408576698